Fix execac tool core encoding #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove residue of SYSEXECAC incomplete insertion. Reverse getac error checks so that not-an-ac comes before other complications.
rminnich
reviewed
Mar 16, 2025
| exec(core, (char **)eargs); | ||
| print("Returned? %r\n"); | ||
| } | ||
| print("Requsting core %lld\n", core); |
| print("Returned? %r\n"); | ||
| } | ||
| print("Requsting core %lld\n", core); | ||
| core = 0xecac | (core << 16); |
There was a problem hiding this comment.
Don't you just love my cute constant that almost spells execac?
| fmtuserstring(&fmt, a, ""); | ||
| argv++; | ||
| } | ||
| break; | ||
| case EXEC: |
There was a problem hiding this comment.
note the problem here: the signature for will be either a va_list containing
(uintptr, char *, va_list)
or a va_list containing (exec classic)
(char *, va_list)
so you'll need to rewrite the EXEC case in places that are intrusive (syscallfmt).
This is my concern about continuing to use exec at all.
I think you had proposed:
to get to an AC, use rfork(RFAC) or rfork(RFPROC|RFAC) and then just exec.
That may still be a better approach. This execac hackery I came up with starts to feel icky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove residue of SYSEXECAC incomplete insertion.
Reverse getac error checks so that not-an-ac comes before other complications.