Feature/e2e tests #53
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR #57 introduces integration test in CI and it also have e2e job that needs to be un-commented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial e2e testing crate idea
In order for e2e tests to work in a cargo workspace project (and separate crate), we need to patch
inkandink_e2ewith the latest master ink which contains fixes for these issues. Expecting these to be in the4.0.2ink release, so we should be able to remove the patch as soon as it's available.Currently I'm importing and using the
equippablecontract for all e2e tests. Perhaps we should have a single "mother" contract in the testing crate which provides a complete implementation of all rmrk functionality, instead of testing examples (which could change). I think there's still a few questions around how this might work.Helper directory to avoid duplicating testing logic with a
call/querynaming convention. These are currently bound to the single importedequippablecontract as described above - making this generic is a bit more complex and will require some more thought.