Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional catalog field to Asset #73

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add optional catalog field to Asset #73

wants to merge 2 commits into from

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented May 23, 2023 •
edited
Loading

As the title mentions this adds a new optional field to the existing Asset struct.
With this new field, the asset_catalog_address mapping is not needed anymore.

  • Add integration test

Closes: #46

@Szegoo Szegoo marked this pull request as ready for review May 23, 2023 14:06
@Szegoo Szegoo requested review from Maar-io and boyswan May 23, 2023 14:06
@Maar-io Maar-io requested a review from bobo-k2 May 29, 2023 08:59
@Maar-io
Copy link
Contributor

Maar-io commented May 29, 2023

@bobo-k2 please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing catalog address when fetching equippable data
2 participants
@Szegoo @Maar-io