docs(vz): record stale socket drill evidence#2601
Conversation
Refs TASK-12136
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request documents the stale-socket drill evidence on a prepared macOS host, updating the evidence tracker and adding a completed backlog task file. The feedback suggests renaming the new backlog file to avoid spaces and mixed casing, and replacing absolute local user paths with relative paths or placeholders to prevent leaking local environment details and improve reproducibility.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @@ -0,0 +1,60 @@ | |||
| --- | |||
There was a problem hiding this comment.
The filename task-12136 - Record-VZ-stale-socket-prepared-host-evidence.md contains spaces and mixed casing. Filenames with spaces can cause issues in command-line scripts, shell utilities, and markdown link references (which require URL encoding like %20). It is highly recommended to rename this file to use a consistent kebab-case naming convention without spaces, such as task-12136-record-vz-stale-socket-prepared-host-evidence.md.
| Worktree: /Users/macbook-dev/Documents/GitHub/tldw_server2/.worktrees/vz-stale-socket-evidence | ||
| Branch: codex/vz-stale-socket-evidence | ||
| Base: origin/dev c20013ecce7e3384ec5faa860434d6bdd76d5407 | ||
| Runtime artifact root: /private/tmp/tldw-vz-stale-socket-stale-socket-20260703-165828 |
There was a problem hiding this comment.
Including absolute local user paths (such as /Users/macbook-dev/...) in committed backlog files leaks local environment details and is not reproducible for other team members. Consider using relative paths or placeholders (e.g., <repo-root>) instead.
| Worktree: /Users/macbook-dev/Documents/GitHub/tldw_server2/.worktrees/vz-stale-socket-evidence | |
| Branch: codex/vz-stale-socket-evidence | |
| Base: origin/dev c20013ecce7e3384ec5faa860434d6bdd76d5407 | |
| Runtime artifact root: /private/tmp/tldw-vz-stale-socket-stale-socket-20260703-165828 | |
| Worktree: <repo-root>/.worktrees/vz-stale-socket-evidence\nBranch: codex/vz-stale-socket-evidence\nBase: origin/dev c20013ecce7e3384ec5faa860434d6bdd76d5407\nRuntime artifact root: /private/tmp/tldw-vz-stale-socket-stale-socket-20260703-165828 |
|
|
||
| Cleanup used vz-helperctl.py stop on the same socket/pid paths and returned exit 0. Post-stop status reported socket=helper_socket_absent, pid_file=ok, process=helper_not_running, and ping=helper_not_running. The status command itself exited 1 because of an unrelated default launchd_plist_mismatch on this host, which is documented in the evidence packet. Helper stdout/stderr logs were retained and empty with SHA-256 e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855. | ||
|
|
||
| Verification: /Users/macbook-dev/Documents/GitHub/tldw_server2/.venv/bin/python -m pytest tldw_Server_API/tests/Infrastructure/test_vz_linux_host_gated_workflow.py -q passed with 23 tests. git diff --check passed. Bandit skipped because the reviewable changes are Markdown/Backlog only; helper build artifacts are untracked evidence setup, not committed source. |
There was a problem hiding this comment.
Avoid using absolute local user paths in the verification commands. Using relative paths (e.g., .venv/bin/python or <repo-root>/.venv/bin/python) is cleaner and more reproducible.
| Verification: /Users/macbook-dev/Documents/GitHub/tldw_server2/.venv/bin/python -m pytest tldw_Server_API/tests/Infrastructure/test_vz_linux_host_gated_workflow.py -q passed with 23 tests. git diff --check passed. Bandit skipped because the reviewable changes are Markdown/Backlog only; helper build artifacts are untracked evidence setup, not committed source. | |
| Verification: .venv/bin/python -m pytest tldw_Server_API/tests/Infrastructure/test_vz_linux_host_gated_workflow.py -q passed with 23 tests. git diff --check passed. Bandit skipped because the reviewable changes are Markdown/Backlog only; helper build artifacts are untracked evidence setup, not committed source. |
PR Summary by Qododocs(vz): record prepared-host stale socket drill evidence (2026-07-03)
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Summary
Verification
/Users/macbook-dev/Documents/GitHub/tldw_server2/.venv/bin/python -m pytest tldw_Server_API/tests/Infrastructure/test_vz_linux_host_gated_workflow.py -qgit diff --checkHuman-authored Change summary still required before merge per repo policy.
Summary by cubic
Add 2026-07-03 prepared-host stale-socket drill evidence for
vz_linux, covering safe inactive socket recovery, helper start/status/protocol checks, explicit stop cleanup, and artifact pointers. Updates the prepared-host evidence log and residual-gap table and adds a backlog entry, fulfilling TASK-12136 with no code or CI trigger changes.Written for commit 05bbe6b. Summary will update on new commits.