-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcuts for navigating between sidebar panels in Vim Mode #160
base: master
Are you sure you want to change the base?
Shortcuts for navigating between sidebar panels in Vim Mode #160
Conversation
Kudos, SonarCloud Quality Gate passed!
|
Hey @lkhphuc and @TDHTTTT, here's a demo of shortcuts that should work better with horizontal themes, what do you think? https://www.youtube.com/watch?v=tPkDJKHU4SY |
Hey that look nice. Thank @tntmarket . Looking forward to this. |
I use the non-horizontal theme and I heavily use the navigation between panels, so I would not want to loose that =\ |
navigating between sidebar panels
f7a5ac1
to
dadaa19
Compare
Kudos, SonarCloud Quality Gate passed!
|
Maybe we can have sidebar pages be separate panels, but make it so navigating past the current panel takes you to the next panel? |
That should work, I think :) |
This makes the panel navigation shortcuts more compatible for both the default Roam experience and horizontal themes (tntmarket#5):
Demo with vanilla theme: https://www.youtube.com/watch?v=jsGXeVCcAvc
Demo with horizontal theme: https://www.youtube.com/watch?v=tPkDJKHU4SY
This is not exactly "backwards compatible", because you can no longer navigate between sidebar pages with straight up
j
/k
etc.I feel like it matches the behavior of "vim windows" more closely though, and it makes it so
gg
andG
go to the beginning/end of the sidebar page, rather than the whole sidebar.