Tweaks #64
Merged
Tweaks #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @robbiebyrd - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| // We need to do an offset on the max number of icons, but use the same positions. | ||
| // For the middle part, we need to figure out how to convert a column count (e.g. the 35th box) | ||
| // to our matrix with an x/y coordiante. |
There was a problem hiding this comment.
suggestion (typo): Typo correction
The word 'coordiante' has been corrected to 'coordinate'. This is a good change for clarity.
Suggested change
| // to our matrix with an x/y coordiante. | |
| // to our matrix with an (x, y) coordinate. |
Comment on lines
+5
to
+6
| interface ClassicyStore { | ||
| } |
There was a problem hiding this comment.
question: Empty interface
The ClassicyStore interface is currently empty. If this is intentional, consider adding a comment explaining why. Otherwise, it might be better to remove it until it is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.