Feature timber sections #466
Conversation
|
Looks promising! I think this would be a worthy addition to I've also included @connorferster as a reviewer as I believe he has more timber expertise than myself! Looking forward to reviewing the complete PR! FYI - the docs for this PR can be found here. |
|
I think it looks good! @jchkoch Glad you dropped the timber rectangular section in favour of the CLT section. Setting the shear modulus of the cross-lams via the If we can get the tests passing, then I am good to go on this one. Edit: Just added a couple of comments. |
| di = float(d[idx]) | ||
| layer = lay_orient[idx] | ||
|
|
||
| if layer is int(0): |
There was a problem hiding this comment.
This seems redundant (int(0)) and misses the mark slightly. Could it not just be if layer == 0?
|
|
||
| Args: | ||
| d: Timber layer section thickness | ||
| lay_orient: List of layer orientation |
There was a problem hiding this comment.
I think lay_orient needs a little more explanation. The implementation of this function assumes certain values to be in there, namely 0 and any other value. The lay orientation could just as well be [0, 1, 0, 1, 0] instead of [0, 90, 0, 90, 0] and the function would work the same (it could also use [0, 34, 0, -15, 0,] and you would get the same result).
I think a list of values to describe the layup makes sense but it seems to rely, somewhat, on "magic values" that are not explained. I think it would be good to say something like:
lay_orient: A list of layer orientations, e.g. [0, 90, 0, 90, 0], where 0 indicates where `timb_mat0` is to be used and where 90 indicates where `timb_mat1` is to be used.
Maybe the user just provides the layup directly by building a list of Material, like:
timb_mat0 = pre.Material(
name="Timber E0",
elastic_modulus=9.5e3,
poissons_ratio=0.35,
density=4.4e-7,
yield_strength=5.5,
color="burlywood",
)
timb_mat90 = pre.Material(
name="Timber90",
elastic_modulus=317,
poissons_ratio=0.35,
density=4.4e-7,
yield_strength=5.5,
color="orange",
)
layup = [timb_mat0, timb_mat90, timb_mat0, timb_mat90, timb_mat0]
sect = clt_rectangular_section(
d=[40, 40, 40],
lay_orient=layup,
b=1000,
)What do you think?
|
@connorferster Thanks for the comments. Unfortunately, I became somewhat busy and haven't managed to follow up. However, I should have a bit more time going forward. |
|
Thanks for checking in @jchkoch. If you don't mind I can update your feature branch to the current state of |
Feature Timber Sections
Discussion: #437
This is a start at adding timber cross-section analysis. Please let me know what you think of the approach to add timber sections. So far I have added geometry creation of layered timber sections. I have added tests for the code that I have written so far.
Moving forward I will be checking and validating the results from the cross-sectional properties calculated for the sections as well as the stress analysis modules.