Skip to content

Commit

Permalink
Use github action setup-chromedriver instead of dbrekelmans/bdi #15
Browse files Browse the repository at this point in the history
cause dbrekelmans/bdi has no support for older php version
@see: https://github.com/marketplace/actions/setup-chromedriver
  • Loading branch information
robertfausk committed Apr 18, 2024
1 parent 5965a0e commit 5285962
Show file tree
Hide file tree
Showing 8 changed files with 1 addition and 51 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ jobs:
run: |
.scenarios.lock/install "${{ matrix.symfony }}" "${DEPENDENCIES}"
- name: Add browser drivers
run: |
vendor/bin/bdi detect drivers
uses: nanasess/setup-chromedriver@v2
- name: Run unit tests
run: |
vendor/bin/phpunit -v
Expand Down
1 change: 0 additions & 1 deletion .scenarios.lock/symfony3/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"friends-of-behat/mink-extension": "^2.3.0"
},
"require-dev": {
"dbrekelmans/bdi": "^1.0",
"g1a/composer-test-scenarios": "^3.0",
"matthiasnoback/symfony-config-test": "^4.1|^5.1",
"phpunit/phpunit": "~7.5|~9.3",
Expand Down
1 change: 0 additions & 1 deletion .scenarios.lock/symfony4/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"friends-of-behat/mink-extension": "^2.3.0"
},
"require-dev": {
"dbrekelmans/bdi": "^1.0",
"g1a/composer-test-scenarios": "^3.0",
"matthiasnoback/symfony-config-test": "^4.1|^5.1",
"phpunit/phpunit": "~7.5|~9.3",
Expand Down
1 change: 0 additions & 1 deletion .scenarios.lock/symfony5/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"friends-of-behat/mink-extension": "^2.3.0"
},
"require-dev": {
"dbrekelmans/bdi": "^1.0",
"g1a/composer-test-scenarios": "^3.0",
"matthiasnoback/symfony-config-test": "^4.1|^5.1",
"phpunit/phpunit": "~7.5|~9.3",
Expand Down
1 change: 0 additions & 1 deletion .scenarios.lock/symfony6/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"friends-of-behat/mink-extension": "^2.3.0"
},
"require-dev": {
"dbrekelmans/bdi": "^1.0",
"g1a/composer-test-scenarios": "^3.0",
"matthiasnoback/symfony-config-test": "^4.1|^5.1",
"phpunit/phpunit": "~7.5|~9.3",
Expand Down
1 change: 0 additions & 1 deletion .scenarios.lock/symfony7/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"friends-of-behat/mink-extension": "^2.3.0"
},
"require-dev": {
"dbrekelmans/bdi": "^1.0",
"g1a/composer-test-scenarios": "^3.0",
"matthiasnoback/symfony-config-test": "^4.1|^5.1",
"phpunit/phpunit": "~7.5|~9.3",
Expand Down
43 changes: 0 additions & 43 deletions bin/updatePantherChromeDriver.sh

This file was deleted.

1 change: 0 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"friends-of-behat/mink-extension": "^2.3.0"
},
"require-dev": {
"dbrekelmans/bdi": "^1.0",
"g1a/composer-test-scenarios": "^3.0",
"matthiasnoback/symfony-config-test": "^4.1|^5.1",
"phpunit/phpunit": "~7.5|~9.3",
Expand Down

0 comments on commit 5285962

Please sign in to comment.