Fix for incorrect line terminators in partials on Windows #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, The change looks fine but can you add a test to check for the issue you fixed? There is one Qt 5 test that is failing but it looks like that is unrelated to the change you made. |
|
Test fails due to the way Qt 5.5 used in test handles double to string conversion. This behaviour was changed in Qt 5.7: "Added support for converting a floating point to its shortest and exact string form, without having to pre-calculate the number of digits." (What's New in Qt 5.7) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the partial file contains Windows-slyle line terminators ("\r\n") it will not be converted into normal C-slyle "\n" for internal use. As a result the rendered file saved as text will have a broked line terminator "\r\r\n".