applied fix to mac os to make it possible to install which was broken#42
Open
zeusintuivo wants to merge 1 commit intorobisonsantos:masterfrom
Open
applied fix to mac os to make it possible to install which was broken#42zeusintuivo wants to merge 1 commit intorobisonsantos:masterfrom
zeusintuivo wants to merge 1 commit intorobisonsantos:masterfrom
Conversation
Owner
|
Can you please share the error you were getting? |
robisonsantos
requested changes
May 13, 2022
Owner
robisonsantos
left a comment
robisonsantos
left a comment
There was a problem hiding this comment.
I really appreciate the help to make EVM better. Thanks for the interest and the contribution
Owner
|
Pls, update your evm to the latest commit and check if that solves the problem you were having. If not, please share the error you get. |
zeusintuivo
force-pushed
the
fix_mac_os_install
branch
from
ea3c3c1 to
abd1aaf
Compare
Author
No, I don't think I took any snapshots |
Author
|
I made all the first batch of changes. Maybe you can do the rest, make it look where you like it better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was not compiling under mac with zsh
the unzip function with - is not allowed under bash, I wonder how was it working all these time with that name.?
Also the chain logic, with && && && with commands, I consider it to be very bad practice.
I tested by compiling now.