-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial refactoring for standardizing linting and testing #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmin764
requested review from
mikahanninen,
custompointofview,
mmokko and
bogdancondurache
September 18, 2023 10:31
4 tasks
cmin764
commented
Sep 19, 2023
cmin764
commented
Sep 19, 2023
mmokko
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'll add the pipeline and merge.
mmokko
force-pushed
the
refactor/linting-testing
branch
from
September 21, 2023 06:13
fe3d92a
to
03df3e2
Compare
mmokko
force-pushed
the
refactor/linting-testing
branch
from
September 21, 2023 06:20
03df3e2
to
862c3b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency of #14
Adds a thin layer of not too opinionated formatting (from our configuration intervention/deviation PoV):
inv lint -a
command❗ By any means this doesn't and shouldn't change behaviour, it's only a cosmetic refactoring aided by Invoke through Poetry commands.
ToDo
build
andpublish
(CI/prod) Invoke commands.Check updated README Development instructions