Fixed code typo in README.md #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optimize_for_inference() method was being assigned back to the model variable, but this method modifies the model in-place and doesn't return the model. This was causing the model to become `None`. Now when we try to use the predict method, it works.
anujonthemove
requested review from
SkalskiP,
probicheaux,
isaacrob-roboflow and
Matvezy
as code owners
|
|
isaacrob-roboflow
approved these changes
Jul 31, 2025
sandesha-hegde
pushed a commit
to sandesha-hegde/rf-detr
that referenced
this pull request
Aug 20, 2025
Fixed code typo in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
predictsection of the Readme.md file, there is a minor issue/typo.The
optimize_for_inference()method was being assigned back to themodelvariable. After running through the codebase, I found out that this method modifies the model in-place and doesn't return the initialized and optimized model. This was causing themodelvariable to becomeNonewhen we try to usemodel.predict()method.Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
No specific test case(s) required.
Any specific deployment considerations
No
Docs
predictsection, it works.