Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 👷 check notebook and automatically create colab link and show better difference in reviewNB #1302

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

onuralpszr
Copy link
Collaborator

@onuralpszr onuralpszr commented Jun 21, 2024

Idea : Any of our pull request has notebook edit or create change(s) we can review easily with single click with colab or reviewnb (login required)

@onuralpszr onuralpszr force-pushed the notebook-bot branch 4 times, most recently from 71f804b to f456d26 Compare June 21, 2024 19:28
@onuralpszr
Copy link
Collaborator Author

onuralpszr commented Jun 21, 2024

Example PR: onuralpszr#135 / onuralpszr#135 (comment)

@onuralpszr onuralpszr changed the title ci: 👷 check notebook and automaticily create colab link and show better difference in reviewNB ci: 👷 check notebook and automatically create colab link and show better difference in reviewNB Jun 21, 2024
…ter difference in reviewNB

Signed-off-by: Onuralp SEZER <[email protected]>
@LinasKo
Copy link
Collaborator

LinasKo commented Jul 5, 2024

We discussed with @SkalskiP and think it's an improvement to the current process.

I've requested authorization internally, for this to be added into supervision.

One thing you mentioned afterwards is:

Btw Can you guys add into Review NB account ?
you can do without but too If you add you can also have extra Review NB bot as well

I didn't quite get the first question - can you explain further?
Then, can this be used without the bot account? My understanding based on the GitHub action code, is that it would extract changed ipynb notebooks and show them in the Colab - not even in ReviewNB. So then, do we need the bot to create the ReviewNB link? Would it need extra permissions?

@onuralpszr
Copy link
Collaborator Author

onuralpszr commented Jul 5, 2024

We discussed with @SkalskiP and think it's an improvement to the current process.

I've requested authorization internally, for this to be added into supervision.

One thing you mentioned afterwards is:

Btw Can you guys add into Review NB account ?
you can do without but too If you add you can also have extra Review NB bot as well

I didn't quite get the first question - can you explain further? Then, can this be used without the bot account? My understanding based on the GitHub action code, is that it would extract changed ipynb notebooks and show them in the Colab - not even in ReviewNB. So then, do we need the bot to create the ReviewNB link? Would it need extra permissions?

2 ways of usage for ReviewNB is without extra permission just login and check notebook difference or If you add bot and give perm to ReviewNB you can read all in here https://www.reviewnb.com/#faq

For colab part you are right It does not need extra permission

@LinasKo
Copy link
Collaborator

LinasKo commented Jul 11, 2024

Let's add this right after 0.22.0 release.
We'll have time to test it out without pushing the CI changes to prod.

@onuralpszr, I'm approving preemptively. If I don't merge by Wednesday, you can do it on my behalf 😉

@onuralpszr
Copy link
Collaborator Author

@LinasKo, Sure we can test after release. Thank you.

@onuralpszr onuralpszr merged commit 2b7cd6a into roboflow:develop Jul 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants