-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: 👷 check notebook and automatically create colab link and show better difference in reviewNB #1302
Conversation
71f804b
to
f456d26
Compare
Example PR: onuralpszr#135 / onuralpszr#135 (comment) |
…ter difference in reviewNB Signed-off-by: Onuralp SEZER <[email protected]>
We discussed with @SkalskiP and think it's an improvement to the current process. I've requested authorization internally, for this to be added into One thing you mentioned afterwards is:
I didn't quite get the first question - can you explain further? |
2 ways of usage for ReviewNB is without extra permission just login and check notebook difference or If you add bot and give perm to ReviewNB you can read all in here https://www.reviewnb.com/#faq For colab part you are right It does not need extra permission |
Let's add this right after 0.22.0 release. @onuralpszr, I'm approving preemptively. If I don't merge by Wednesday, you can do it on my behalf 😉 |
@LinasKo, Sure we can test after release. Thank you. |
Idea : Any of our pull request has notebook edit or create change(s) we can review easily with single click with colab or reviewnb (login required)