Dependence removal #49
Open
+15
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2024 04:59
fixes the index out of bounds on some searches cause of the elevation not being in the response
|
I haven't checked this, if you delete the cassettes and run the tests, do the cassettes get regenerated? My only concern is that pytest VCR only works with the requests library, just want to double check. |
|
Apart from the eight tests failing because something is not working with my API key, all other tests are passing and still generate the cassettes. httpx was built to be a drop-in replacement for requests, so luckily, it seems to work fine. You might want to test the API test though as I still haven't been able to get my API key to work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes everything to using httpx as there's no need to use to different HTTP libraries for the same job