fix timeout in initialization #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PINTO0309
added a commit
to PINTO0309/rplidar_ros
that referenced
this pull request
May 2, 2018
PINTO0309
added a commit
to PINTO0309/rplidar_ros
that referenced
this pull request
May 2, 2018
PINTO0309
added a commit
to PINTO0309/rplidar_ros
that referenced
this pull request
May 2, 2018
PINTO0309
added a commit
to PINTO0309/rplidar_ros
that referenced
this pull request
May 2, 2018
PINTO0309
added a commit
to PINTO0309/rplidar_ros
that referenced
this pull request
May 2, 2018
PINTO0309
added a commit
to PINTO0309/rplidar_ros
that referenced
this pull request
May 2, 2018
2018.05.03 Pull requests Merged robopeak#41, robopeak#42, robopeak#43, robopeak#49, robopeak#50
SGSSGene
force-pushed
the
bugfix/hangOnSerialization
branch
from
1182900
to
5c71ca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is supposed to fix the timeout parameter in the raw_serial::waitfordata function.
The Issue turns up when for example the call ptr->waitfordata(2, 1000, 0) is being made.
Now for some reason the serial device only sends one byte instead of two. This will cause the later call
int n = ::select(max_fd, &input_set, NULL, NULL, &timeout_val);to never flag "TIMEOUT", it will always signal that the fd is ready to be read.This causes the whole system to hang at this point and never return.
My fix forces to break out of the loop if the TIMEOUT is being reached.