Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change document structure #127

Merged
merged 7 commits into from
Nov 23, 2018
Merged

Change document structure #127

merged 7 commits into from
Nov 23, 2018

Conversation

danila19991
Copy link
Member

@danila19991 danila19991 commented Nov 22, 2018

Pull Request

ВАЖНО: Пожалуйста, не создавайте Pull Request, если не созданы issues, которые Ваш PR решает.

Описание

Для внесения изменений в основные ветки нужно получить разрешения от тимлидов команд или соответствующих ревьюверов Ваших репозиториев.

Список изменений:

  1. Изменил модель документа в соответствии со 2 задачей

Закрытые issues

closes #126
closes #124

@danila19991 danila19991 added priority/high High issue priority area/rest-api Additional label for issues related to REST labels Nov 22, 2018
@danila19991 danila19991 self-assigned this Nov 22, 2018
@navolotsky
Copy link
Member

В text_source_url для положений будет храниться позиция в сохраненном html, например
image

Не возникнет ли проблем с тем, что его тип задан как URLField?

@danila19991 danila19991 added the type/task Formalizing definition of something that should be realized label Nov 22, 2018
Copy link
Member

@navolotsky navolotsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/models.py
26 строка
заменить absolute_path = models.TextField(blank=False)
на absolute_path = models.TextField()

core/models.py Outdated Show resolved Hide resolved
core/models.py Outdated
supertype = models.TextField(blank=False)
doc_type = models.TextField(blank=False)
title = models.TextField(blank=False)
release_date = models.DateField(blank=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если я правильно помню то у ребят не стандартный формат хранения даты

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dd.mm.yyyy
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest-api Additional label for issues related to REST priority/high High issue priority type/task Formalizing definition of something that should be realized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants