-
Notifications
You must be signed in to change notification settings - Fork 25
[feat] Add new method to disconnect to redis #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucas-m-ribeiro
wants to merge
7
commits into
robotframework-thailand:master
Choose a base branch
from
lucas-m-ribeiro:feature/add-redis-method-to-disconnect
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
13f1e05
feat: add new method disconnect_to_redis
lucas-m-ribeiro 44c09d5
test: add unit test to new method disconnect_to_redis
lucas-m-ribeiro b8f70e9
Update RedisLibraryKeywords.py
lucas-m-ribeiro 53297d9
Update RedisLibraryKeywords.py
lucas-m-ribeiro cecf870
[fix] replacing method close to connection pool
lucas-m-ribeiro cf1facd
fix unit test
lucas-m-ribeiro c3393fb
update: change method name
lucas-m-ribeiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
|
|
||
| __author__ = 'Traitanit Huangsri' | ||
| __email__ = '[email protected]' | ||
|
|
||
| from unittest.mock import MagicMock, patch | ||
| from RedisLibrary import RedisLibrary | ||
| import unittest, fakeredis, ast | ||
|
|
||
|
|
@@ -315,5 +315,10 @@ def test_delete_item_from_list_redis_item_not_matched(self): | |
| with self.assertRaises(AssertionError): | ||
| self.redis.delete_item_from_list_redis(self.fake_redis, 'Country', 2, 'Spain') | ||
|
|
||
| def test_disconect_to_redis(self): | ||
| self.fake_redis.close = MagicMock() | ||
| self.assertIsNone(self.redis.disconnect_to_redis(self.fake_redis)) | ||
| self.fake_redis.close.assert_called_once() | ||
|
|
||
| def tearDown(self): | ||
| self.fake_redis.flushall() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.