Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmap IEventCommandMap before remapping it #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccapndave
Copy link

IEventCommandMap was already mapped in my application causing the following error:

Error: Injector mapping override for type [class IEventCommandMap] with name 
    at robotlegs.bender.extensions.vigilance::VigilanceExtension/mappingOverrideHandler()[/Development/Projects/Robotlegs/robotlegs-framework/src/robotlegs/bender/extensions/vigilance/VigilanceExtension.as:61]

Therefore I added a line to remove it before remapping it (if necessary).

@darscan
Copy link
Member

darscan commented Sep 16, 2013

I'm not fully clued up on this extension, but surely the mapping error provides useful feedback? Doesn't this patch silently hide something that an end user should be aware of? @creynders thoughts?

@creynders
Copy link
Member

Hmmm, yeah I don't think it's a good idea to silence the remapping. I for one want to know when an extension remaps something. It's best to make sure nothing's mapped to IEventCommandMap IMO.

@ccapndave
Copy link
Author

Ah - I guess its because I am using the MVCSBundle which premaps IEventCommandMap. However, I think lots of people will be using this bundle so maybe the best way to fix this is simply to add a note to the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants