Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding files for walking autonomous on SN000 #193

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

S-Dafarra
Copy link
Collaborator

@S-Dafarra
Copy link
Collaborator Author

@GiulioRomualdi friendly ping

@S-Dafarra
Copy link
Collaborator Author

I borrowed two commits from #194:

@GiulioRomualdi
Copy link
Member

I borrowed two commits from #194:

I would remove these two commits and keep them in one #194

@S-Dafarra
Copy link
Collaborator Author

I borrowed two commits from #194:

I would remove these two commits and keep them in one #194

Those are extremely useful for autonomy too. What is the plan for #194?

@GiulioRomualdi
Copy link
Member

I borrowed two commits from #194:

I would remove these two commits and keep them in one #194

Those are extremely useful for autonomy too. What is the plan for #194?

As you suggested in #194 (comment), the logic is somewhat hidden and could be implemented more clearly. Since PR #194 covers multiple features (angular momentum and temperature), splitting it into two parts might be better.

Note that adding angular momentum minimization during walking we decide to disable the control of the arms by the autonomy module, which means no box can be carried. One possible solution could be to generate an angular momentum reference from the autonomy module. We can explore how to approach this.

@S-Dafarra
Copy link
Collaborator Author

I see. The commit(s) I took instead are quite plain and simple. My proposal then would be to merge this, and then rebase #194 on top of master afterward (something I can take care of). Does it make sense?

@GiulioRomualdi GiulioRomualdi merged commit ed7bd5b into master Dec 3, 2024
1 check passed
@GiulioRomualdi GiulioRomualdi deleted the autonomous000 branch December 3, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants