-
Notifications
You must be signed in to change notification settings - Fork 197
Add Motor Temperature to stateExt and Convert PWM to Float #3188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Motor Temperature to stateExt and Convert PWM to Float #3188
Conversation
- Stream the motor temperature as float - modify the PWM to be streamed as float
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in |
Note Since this PR will not be merged into YARP soon (the next YARP release is expected in the coming months), I have already prepared two branches that can be used in YARP to collect the temperature using this feature:
Please note that this modification is a breaking change, as it alters the structure of |
After a discussion with @randaz81 and @traversaro, we decided to add motor temperature data to
stateExt
, streamed as a vector of floats. To avoid increasing the message size, we also decided to convert the PWM data from a vector of doubles to a vector of floats.This pull request introduces several changes to the
RemoteControlBoard
and related components to support temperature data. The modifications affect data structures, methods, and interfaces to handle temperature readings properly.The PR consists of two commits:
float32
conversion inBottle
. Without this, reading from thestateExt
port results in the following error:Note
I also regenerated the
jointData.cpp
andjointData.h
to be compliant with the new thrift