Add infix feature extractors samples (#1568) #1733
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // } | ||
| // } | ||
|
|
||
| data class Person2( |
There was a problem hiding this comment.
TODO: Merge with Person class
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1733 +/- ##
=========================================
Coverage 92.68% 92.68%
Complexity 116 116
=========================================
Files 442 442
Lines 4895 4895
Branches 234 234
=========================================
Hits 4537 4537
Misses 311 311
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
robstoll
reviewed
Apr 2, 2024
.../src/commonTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FeatureExtractorSamples.kt
Outdated
Show resolved
Hide resolved
robstoll
reviewed
Apr 2, 2024
| fails { | ||
| expect(person) its { age } toBeLessThan 20 toBeGreaterThan 30 | ||
| // | | not evaluated/reported because `toBeLessThan` already fails | ||
| // | | use an expectation-group block; for more details: https://github.com/robstoll/atrium#define-single-expectations-or-expectation-groups |
...x/src/commonTest/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/FeatureExtractorSamples.kt
Outdated
Show resolved
Hide resolved
First attempt
constantine-zubrylin
force-pushed
the
1568-add-FeatureExtractorSamples-to-api-infix
branch
from
9f60da8
to
7d3ddf4
Compare
…trium/api/infix/en_GB/samples/FeatureExtractorSamples.kt Co-authored-by: Robert Stoll <[email protected]>
|
@constantine-zubrylin just as info, did not have a look again, let me know once it is ready for review |
Sure. Sorry, I have some problems with free time, but I'll return to the ticket soon. |
|
No stress and thanks for your contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds infix feature extractors samples based on fluent tests
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.