update unikernels to mirage 4.5.0 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
commented
May 9, 2024
| open Mirage | ||
|
|
||
| let data_key = Key.(value @@ kv_ro ~group:"data" ()) | ||
| let data = generic_kv_ro ~key:data_key "configuration" | ||
| let private_netif = netif ~group:"private" "private" | ||
| let private_ethernet = etif private_netif | ||
| let private_arp = arp private_ethernet | ||
| (* this is temporary until we find a better way *) | ||
| let ip = Runtime_arg.V4.network ~group:"private" (Ipaddr.V4.Prefix.of_string_exn "10.0.0.2/24") |
There was a problem hiding this comment.
we used to use Key_gen.private_ipv4 () -- but now that's not available anymore. We now re-create the same key, once for passing it to our unikernel, and once it is created in the call to create_ipv4 below.
A solution I can see is to enhance our Ip.S interface - which at the moment has a get_ip : t -> ipaddr list, to instead contain get_ip : t -> ipaddr.Prefix.t list. I'll work on this.
There was a problem hiding this comment.
mirage/mirage-tcpip#516 will allow us to remove this let ip = ... from mirage-nat and mirage-router.
|
the mirage-client and mirage-server continue to work with mirage 4.4, but for mirage-nat and mirage-router we needed to modify code which is not compatible with mirage 4.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.