-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #13 from rocjs/fix/make-sure-universal-config-is-es5
fix(roc-package-web-app-react): Use ES5 for universal-config
- Loading branch information
Showing
1 changed file
with
20 additions
and
13 deletions.
There are no files selected for viewing
33 changes: 20 additions & 13 deletions
33
packages/roc-package-web-app-react/src/app/shared/universal-config.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,32 @@ | ||
/* globals window */ | ||
/** | ||
* Universal Configuration Manager | ||
* | ||
* Manages both __application__ configuration and __Roc__ configuration. | ||
* On the server the configurations will be fetched directly and on the client it's expected that the configuration | ||
* is available on `window` as `ROC_CONFIG` and `APP_CONFIG`. | ||
* | ||
* appConfig will only contain what has been selected by `runtime.configWhitelistProperty`. That means if you want | ||
* to read the full configuration on the server you will need to read it directly from node-config. | ||
*/ | ||
/* eslint-disable no-var, import/no-mutable-exports */ | ||
|
||
export const rocConfig = (function getRocConfig() { | ||
/** | ||
* Universal Configuration Manager | ||
* | ||
* Manages both __application__ configuration and __Roc__ configuration. | ||
* On the server the configurations will be fetched directly and on the client it's expected that the configuration | ||
* is available on `window` as `ROC_CONFIG` and `APP_CONFIG`. | ||
* | ||
* appConfig will only contain what has been selected by `runtime.configWhitelistProperty`. That means if you want | ||
* to read the full configuration on the server you will need to read it directly from node-config. | ||
*/ | ||
|
||
/** | ||
* Important to use "var" here over "const" since this might run in PhantomJS | ||
* that does not support them, basically this needs to be ES5. | ||
*/ | ||
|
||
export var rocConfig = (function getRocConfig() { | ||
return typeof window !== 'undefined' ? window.ROC_CONFIG : require('roc').getSettings(); // eslint-disable-line | ||
}()); | ||
|
||
const whiteListed = () => ( | ||
var whiteListed = () => ( | ||
rocConfig.runtime.configWhitelistProperty ? | ||
require('config')[rocConfig.runtime.configWhitelistProperty] : // eslint-disable-line | ||
undefined | ||
); | ||
|
||
export const appConfig = (function getAppConfig() { | ||
export var appConfig = (function getAppConfig() { | ||
return typeof window !== 'undefined' ? window.APP_CONFIG : whiteListed(); | ||
}()); |