Merge pull request #6 from rocjs/feature/static-maxage

Add support for max-age in the koa static middleware through settings
rocjs · Apr 22, 2016 · 7ecba1b · 7ecba1b
2 parents 0e949e1 + 6c99769
commit 7ecba1b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/packages/roc-package-web-app/app/server/index.js b/packages/roc-package-web-app/app/server/index.js
@@ -55,10 +55,17 @@ export default function createServer(options = {}, beforeUserMiddlewares = []) {
 
     const makeServe = (toServe = []) => {
         toServe = [].concat(toServe);
+
+        const staticSettings = process.env.NODE_ENV === 'production' ? runtimeSettings.koa.staticServe : {};
+
         for (const path of toServe) {
-            // We use defer here to no try to fetch a file if we have set something on body, something that is done in
+            server.use(serve(path, {
+            // We use defer as default here to no try to fetch a file
+            // if we have set something on body, something that is done in
             // redirect. This because https://github.com/koajs/send/issues/51
-            server.use(serve(path, { defer: true }));
+                defer: true,
+                ...staticSettings
+            }));
         }
     };
 

diff --git a/packages/roc-package-web-app/src/config/roc.config.js b/packages/roc-package-web-app/src/config/roc.config.js
@@ -27,6 +27,9 @@ export default {
                 trailingSlashes: {
                     enabled: true,
                     defer: true
+                },
+                staticServe: {
+                    maxage: 60000
                 }
             }
         }

diff --git a/packages/roc-package-web-app/src/config/roc.config.meta.js b/packages/roc-package-web-app/src/config/roc.config.meta.js
@@ -42,6 +42,9 @@ export default {
                     trailingSlashes: {
                         enabled: 'Set to true to enforce trailing slashes, false to remove them and null for no rule.',
                         defer: 'If this should be performed after looking for a file on disk.'
+                    },
+                    staticServe: {
+                        maxage: 'Browser cache max-age in milliseconds. Production only.'
                     }
                 }
             }