Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the opencv zip now contains a folder with version number #19

Merged
merged 1 commit into from
Mar 12, 2015

Conversation

planthaber
Copy link
Member

No description provided.

@planthaber
Copy link
Member Author

this only affects new bootstraps on debian (and the buildserver)

@planthaber
Copy link
Member Author

please also re-consider #14

@marvin2k
Copy link
Contributor

Wouldn't it be nice to use their official github mirror? Comes with tags

@planthaber
Copy link
Member Author

which is part of #14 i mentioned to reconsider

@marvin2k
Copy link
Contributor

Why is the source-package downloaded and compiled at all? All the supported os install the packaged version anyways.

Debian Testing is not catched -- but i suspect just because noone removed the 'wheezy,sid': line

@planthaber
Copy link
Member Author

All the supported os install the packaged version anyways

The default only applies for "ubuntu" as it is listed below ubuntu, there is no default for debian

@marvin2k
Copy link
Contributor

Ok, but Trusty has libopencv-dev as 2.4.8 and Debian Testing (sid) somes with libopencv-dev as 2.4.9. So is there any reason to download and compile the sources?

@planthaber
Copy link
Member Author

No idea, didn't put it into here, just trying to fix it without changing too mush.

Btw. jessie is the current debian testing, sid is "unstable"

@marvin2k
Copy link
Contributor

I created #21 to use the system-package

doudou added a commit that referenced this pull request Mar 12, 2015
the opencv zip now contains a folder with version number
@doudou doudou merged commit 22a432d into rock-core:master Mar 12, 2015
@doudou
Copy link
Member

doudou commented Mar 12, 2015

OK ... let's merge this one. It is by far the least intrusive. In addition to the fix to make sure we install the debian package on OSes where it is supported, we should be fine.

@doudou
Copy link
Member

doudou commented Mar 12, 2015

Then if the consensus is to delete the source package completely, then so be it.... Won't be a lot harder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants