chore: remove base/templates/bundles from rock.core #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhonasiv
reviewed
Jan 28, 2025
04stable.autobuild
Outdated
| @@ -76,6 +76,7 @@ in_flavor 'master', 'stable' do | |||
| import_package 'base/templates/cmake_vizkit_widget' | |||
| import_package 'base/templates/vizkit3d_plugin' | |||
| import_package 'base/templates/bundle' | |||
| remove_fromm_default "base/templates/bundle" | |||
There was a problem hiding this comment.
Suggested change
| remove_fromm_default "base/templates/bundle" | |
| remove_from_default "base/templates/bundle" |
The rock-create-bundle now points to manual step-by-step from the rock&syskit documentation on how to create a bundle. The template is obsolete, and difficult to keep in lockstep with the canonical way to create syskit app, that is `syskit gen`
doudou
force-pushed
the
remove-base-templates-bundle
branch
from
996f790 to
3cfc57b
Compare
jhonasiv
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
The rock-create-bundle now points to manual step-by-step from the rock&syskit documentation on how to create a bundle.
The template is obsolete, and difficult to keep in lockstep with the canonical way to create syskit app, that is
syskit gen