disable examples and allow parallel building #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve build time:
On my system:
before changes:
$> time rake
real 5m4.414s
user 2m12.522s
sys 0m26.848s
after changes:
$> rake clean
$> time rake
real 1m13.996s
user 2m28.404s
sys 0m17.292s
doudou
reviewed
Jan 11, 2023
| @@ -10,7 +10,7 @@ if windows | |||
| COPY = 'copy' | |||
| DEL = 'del' | |||
| else | |||
| MAKE = 'make' | |||
| MAKE = 'make -j' | |||
There was a problem hiding this comment.
If you want parallel building, pick it up from an environment variable. The default should be no parallel.
Comment on lines
-49
to
+62
| task :build_examples do | ||
| # Go into the examples directory and look for all the makefiles and build them | ||
| Dir['examples/**/makefile'].each do |file| | ||
| if windows | ||
| system("cd #{File.dirname(file).gsub('/', '\\')} && #{MAKE}") | ||
| else | ||
| system("cd #{File.dirname(file)} && #{MAKE}") | ||
| end | ||
| end | ||
| end | ||
|
|
||
| task :examples => [:build_examples] do | ||
| system('cd examples && ruby run_all.rb') | ||
| end | ||
| # task :build_examples do | ||
| # # Go into the examples directory and look for all the makefiles and build them | ||
| # Dir['examples/**/makefile'].each do |file| | ||
| # if windows | ||
| # system("cd #{File.dirname(file).gsub('/', '\\')} && #{MAKE}") | ||
| # else | ||
| # system("cd #{File.dirname(file)} && #{MAKE}") | ||
| # end | ||
| # end | ||
| # end | ||
|
|
||
| # task :examples => [:build_examples] do | ||
| # system('cd examples && ruby run_all.rb') | ||
| # end |
There was a problem hiding this comment.
Keep the tasks, but tune the :default target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve build time:
On my system:
before changes:
$> time rake
real 5m4.414s
user 2m12.522s
sys 0m26.848s
after changes:
$> rake clean
$> time rake
real 1m13.996s
user 2m28.404s
sys 0m17.292s