Revert "Add propagateNeedsSignal function."

This reverts commit c512431.

Accidental push of non-tested patch (contained a type in RemoteChannelElement).

rtt/base/ChannelElementBase.hpp

@@ -132,14 +132,6 @@ namespace RTT { namespace base {
          */
         void setOutput(shared_ptr output);
 
-        /** Tell if the output needs to be signaled when new data are
-         * available.
-         * By default, the channel element forwards the call to its input
-         *
-         * @param true_false true if need signaling.
-         */
-        virtual void propagateNeedsSignaling(bool);
-
         /** Signals that there is new data available on this channel
          * By default, the channel element forwards the call to its output
          *

rtt/base/ChannelInterface.cpp

@@ -120,14 +120,6 @@ void ChannelElementBase::clear()
         input->clear();
 }
 
-void ChannelElementBase::propagateNeedsSignaling(bool true_false)
-{
-    // we go against the data stream
-    shared_ptr input = getInput();
-    if (input)
-        input->propagateNeedsSignaling(true_false);
-}
-
 bool ChannelElementBase::signal()
 {
     shared_ptr output = getOutput();

rtt/base/InputPortInterface.cpp

@@ -134,12 +134,6 @@ void InputPortInterface::signal()
 void InputPortInterface::signalInterface(bool true_false)
 {
     msignal_interface = true_false;
-    // propagate the information to the output end
-    std::list<internal::ConnectionManager::ChannelDescriptor> channels = cmanager.getChannels();
-    std::list<internal::ConnectionManager::ChannelDescriptor>::iterator it;
-    for(it = channels.begin(); it != channels.end(); ++it) {
-        it->get<1>()->propagateNeedsSignaling(true_false);
-    }
 }
 #endif
 FlowStatus InputPortInterface::read(DataSourceBase::shared_ptr source, bool copy_old_data)

rtt/transports/corba/DataFlow.idl

@@ -74,14 +74,6 @@ module RTT
          * side is such that they can relay a signal or disconnect.
          */
         void setRemoteSide(in CRemoteChannelElement other);
-
-        /**
-         * Used by the 'remote' side to tell that it needs signaling
-         * when new data is available for reading.
-         * @param true_false true if the remote side is an "eventPort".
-         */
-        void remotePropagateNeedsSignaling(in boolean true_false);
-
         /**
          * Used by the 'remote' side to inform this channel element that new data
          * is available for reading.

rtt/transports/corba/RemoteChannelElement.hpp

@@ -71,10 +71,6 @@ namespace RTT {
 	     * In pull mode, we don't send data, just signal it and remote must read it back.
 	     */
 	    bool pull;
-	    /**
-	     * In pull mode, we don't send data neither signal if not needed.
-	     */
-	    bool need_signal;
 
             /** This is used on to read the channel */
             typename base::ChannelElement<T>::value_t sample;
@@ -99,7 +95,7 @@ namespace RTT {
 	      value_data_source(new internal::ValueDataSource<T>),
 	      ref_data_source(new internal::LateReferenceDataSource<T>),
 	      const_ref_data_source(new internal::LateConstReferenceDataSource<T>),
-          valid(true), pull(is_pull), need_signal(false,
+              valid(true), pull(is_pull),
 	      msender(sender),
               write_any(new CORBA::Any)
             {
@@ -127,30 +123,6 @@ namespace RTT {
             { this->deref(); }
 
 
-            /**
-             * CORBA IDL function.
-             * CRemoteChannelElement_i propagateNeedsSignaling implementation.
-             */
-            void remotePropagateNeedsSignaling(CORBA::Boolean true_false) ACE_THROW_SPEC ((
-          	      CORBA::SystemException
-          	    ))
-            { 
-                // forward too.
-                base::ChannelElementBase::propagateNeedsSignaling(true_false);
-                // update the cache
-                need_signal = true_false; 
-            }
-
-            /**
-             * base::ChannelElement<T> propagateNeedsSignaling implementation.
-             */
-            void propagateNeedsSignaling(bool true_false)
-            { 
-                if ( !CORBA::is_nil(remote_side.in()) )
-                    // FIXME should we care about the RT here, as in signal ?
-                    remote_side->remotePropagateNeedsSignaling(true_false);
-            }
-
             /**
              * CORBA IDL function.
              */
@@ -166,9 +138,6 @@ namespace RTT {
                 // intercept signal if no remote side set.
                 if ( CORBA::is_nil(remote_side.in()) )
                     return true;
-                // intercept signal if no signal needed.
-                if ( !need_signal )
-                    return true;
                 // Remember that signal() is called in the context of the one
                 // that wrote the data, so we must decouple here to keep hard-RT happy.
                 // the dispatch thread must read the data and send it over by calling transferSample().
@@ -182,7 +151,7 @@ namespace RTT {
                     return;
                 //log(Debug) <<"transfering..." <<endlog();
                 // in push mode, transfer all data, in pull mode, only signal once for each sample.
-                if ( pull && need_signal ) {
+                if ( pull ) {
                     try
                     { valid = remote_side->remoteSignal(); }
 #ifdef CORBA_IS_OMNIORB
@@ -197,7 +166,7 @@ namespace RTT {
                         log(Error) << "caught CORBA exception while signalling our remote endpoint: " << e._name() << endlog();
                         valid = false;
                     }
-                } else if (!pull) {
+                } else {
                     //log(Debug) <<"...read..."<<endlog();
                     while ( this->read(sample, false) == NewData && valid) {
                         //log(Debug) <<"...write..."<<endlog();