Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node 19 #186

Closed
vscheuber opened this issue Jan 20, 2023 · 1 comment · Fixed by #207
Closed

Support Node 19 #186

vscheuber opened this issue Jan 20, 2023 · 1 comment · Fixed by #207
Assignees
@vscheuber
Labels
enhancement New feature or request

Comments

@vscheuber
Copy link
Contributor

Node 19 removed support for the flag --experimental-specifier-resolution which Frodo relies on: nodejs/node#44859

To support the current node release, Frodo should explore using a loader instead.
@vscheuber vscheuber added the enhancement New feature or request label Jan 20, 2023
@vscheuber vscheuber self-assigned this Jan 23, 2023
@vscheuber
Copy link
Contributor Author

I believe I figured out a way to support node 19 with the help of the nodejs team: nodejs/node#46298

I have a working prototype but need to test backwards compatibility and compatibility with pkg for our binaries.

@vscheuber vscheuber mentioned this issue Feb 17, 2023
Merged
vscheuber added a commit to vscheuber/frodo-cli that referenced this issue Apr 18, 2023
@vscheuber
fixes rockcarver#214 - a regression introduced in rockcarver#186
5ac1576
@vscheuber vscheuber mentioned this issue Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vscheuber vscheuber

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MINOR RELEASE vscheuber/frodo-cli
1 participant
@vscheuber