Prevent vacant minipool from refunding

rocket-pool · Mar 13, 2023 · 503c515 · 503c515
1 parent 1367c19
commit 503c515
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/contracts/contract/minipool/RocketMinipoolDelegate.sol b/contracts/contract/minipool/RocketMinipoolDelegate.sol
@@ -690,6 +690,8 @@ contract RocketMinipoolDelegate is RocketMinipoolStorageLayout, RocketMinipoolIn
 
     /// @dev Transfer refunded ETH balance to the node operator
     function _refund() private {
+        // Prevent vacant minipools from calling
+        require(vacant == false, "Vacant minipool cannot refund");
         // Update refund balance
         uint256 refundAmount = nodeRefundBalance;
         nodeRefundBalance = 0;

diff --git a/test/minipool/minipool-vacant-tests.js b/test/minipool/minipool-vacant-tests.js
@@ -155,6 +155,14 @@ export default function() {
         });
 
 
+        it(printTitle('node operator', 'cannot call refund while vacant'), async () => {
+            // Create a vacant minipool with current balance of 33
+            let minipool = await createVacantMinipool('8'.ether, {from: node}, null, '33'.ether);
+            // Try to refund
+            await shouldRevert(refund(minipool, { from: node }), 'Was able to refund', 'Vacant minipool cannot refund');
+        });
+
+
         it(printTitle('node operator', 'can not create a vacant minipool with an existing pubkey'), async () => {
             // Create minipool with a pubkey
             const pubkey = getValidatorPubkey();