Do not bother with rETHBefore

Sending rETH to this contract means sending it to whatever lucky NO calls depositAndMint next.
rocket-pool · Nov 14, 2022 · 9240164 · 9240164
1 parent 9c90a38
commit 9240164
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/contracts/contract/node/RocketNodeDeposit.sol b/contracts/contract/node/RocketNodeDeposit.sol
@@ -73,14 +73,11 @@ contract RocketNodeDeposit is RocketBase, RocketNodeDepositInterface {
     }
 
     function _mint(uint256 _mintEthAmount) private {
-        // Save current rETH balance (for calculating how much rETH is minted)
-        RocketTokenRETHInterface rocketTokenRETH = RocketTokenRETHInterface(getContractAddress("rocketTokenRETH"));
-        uint256 rETHBefore = rocketTokenRETH.balanceOf(address(this));
         // Deposit ETH to mint rETH
-        RocketDepositPoolInterface rocketDepositPool = RocketDepositPoolInterface(getContractAddress("rocketDepositPool"));
-        rocketDepositPool.deposit{value: _mintEthAmount}();
+        RocketDepositPoolInterface(getContractAddress("rocketDepositPool")).deposit{value: _mintEthAmount}();
         // Transfer minted rETH back to the caller
-        rocketTokenRETH.transfer(msg.sender, rocketTokenRETH.balanceOf(address(this)) - rETHBefore);
+        RocketTokenRETHInterface rocketTokenRETH = RocketTokenRETHInterface(getContractAddress("rocketTokenRETH"));
+        rocketTokenRETH.transfer(msg.sender, rocketTokenRETH.balanceOf(address(this)));
     }