Skip to content

fix memory_persistent double forwarding - #1702

Draft
erichanwang wants to merge 1 commit into
rocketride-org:developfrom
erichanwang:fix/memory-persistent-prevent-default
Draft

fix memory_persistent double forwarding#1702
erichanwang wants to merge 1 commit into
rocketride-org:developfrom
erichanwang:fix/memory-persistent-prevent-default

Conversation

@erichanwang

Copy link
Copy Markdown

fixes #1638

changes:

  • call preventDefault() after every explicit writeQuestions / writeAnswers forward in memory_persistent
  • assert the lane is claimed in the existing lifecycle tests

verification:

  • git diff --check
  • PYTHONPATH=nodes/src .venv/bin/python - <<PY ... pytest.main(["nodes/test/memory_persistent/test_node.py", "-q"]) ... PY -> 87 passed
  • pre-commit hook: gitleaks, ruff check, ruff format --check

@github-actions github-actions Bot added the module:nodes Python pipeline nodes label Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f45dac0e-6b6b-4a48-a4ef-06f46b9566e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:nodes Python pipeline nodes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memory_persistent double-forwards questions and answers (missing preventDefault)

1 participant