Skip to content

fix sendFiles maxConcurrent - #1716

Draft
erichanwang wants to merge 1 commit into
rocketride-org:developfrom
erichanwang:fix/sendfiles-max-concurrent
Draft

fix sendFiles maxConcurrent#1716
erichanwang wants to merge 1 commit into
rocketride-org:developfrom
erichanwang:fix/sendfiles-max-concurrent

Conversation

@erichanwang

Copy link
Copy Markdown

fixes #1381

changes:

  • add the documented optional maxConcurrent argument to TypeScript sendFiles
  • run uploads through a bounded worker loop instead of starting every upload at once
  • pass the CLI --max-concurrent option through to sendFiles
  • update the checked-in shell-api type signature and add a focused concurrency regression

verification:

  • git diff --check
  • pnpm install --frozen-lockfile
  • pnpm exec jest tests/RocketRideClient.test.ts --runInBand -t "sendFiles concurrency" from packages/client-typescript -> 1 passed
  • pnpm exec tsc -p tsconfig.json --noEmit from packages/client-typescript
  • pnpm exec tsc -p tsconfig.cli.json --noEmit from packages/client-typescript
  • pre-commit hook: gitleaks

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 980e4f73-d28e-4e6f-b02a-e25d15e1a8f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sendFiles() ignores its documented maxConcurrent argument

1 participant