Skip to content

fix pinecone transform sub-key - #1720

Draft
erichanwang wants to merge 1 commit into
rocketride-org:developfrom
erichanwang:fix/RR-1664-pinecone-sub-key
Draft

fix pinecone transform sub-key#1720
erichanwang wants to merge 1 commit into
rocketride-org:developfrom
erichanwang:fix/RR-1664-pinecone-sub-key

Conversation

@erichanwang

Copy link
Copy Markdown

fixes #1664

changes

  • key Pinecone transform state by hash(api key), profile, and index
  • keep raw API key material out of transform tags
  • document the one-time re-ingest behavior after the key changes

verification

  • PYTHONPATH=nodes/src:nodes/test:packages/server/engine-lib/rocketlib-python/lib /home/ericwang/Projects/upstream-contributions/rocketride-issue1638/.venv/bin/python -m pytest nodes/test/store_pinecone/test_transform_sub_key.py -q
  • /home/ericwang/Projects/upstream-contributions/rocketride-issue1638/.venv/bin/python -m ruff check nodes/src/nodes/store_pinecone/IGlobal.py nodes/test/store_pinecone/test_transform_sub_key.py
  • /home/ericwang/Projects/upstream-contributions/rocketride-issue1638/.venv/bin/python -m ruff format --check nodes/src/nodes/store_pinecone/IGlobal.py nodes/test/store_pinecone/test_transform_sub_key.py
  • pre-commit hook: gitleaks, ruff-check, ruff-format

local note: nodes/test/store_pinecone/test_record_updates.py still cannot collect in this checkout because the engine binding module engLib is not importable here.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1506d812-32bc-4fa3-a3b2-8fd6a1ae71cf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added docs Documentation module:nodes Python pipeline nodes labels Jul 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation module:nodes Python pipeline nodes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

store_pinecone: transform sub-key does not distinguish destinations

1 participant