The function Jordan_form is modified to have simpler type (for outputs)#63
Open
ybertot wants to merge 3 commits intorocq-community:masterfrom
Open
The function Jordan_form is modified to have simpler type (for outputs)#63ybertot wants to merge 3 commits intorocq-community:masterfrom
ybertot wants to merge 3 commits intorocq-community:masterfrom
Conversation
characteristic theorems are modified accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
characteristic theorems are modified accordingly.
Before the change, function Jordan_form had type:
forall (F : closedFieldType) (n : nat) (A : 'M[F]_n.+1), 'M[F]_(size_sum[seq x.2.-1 | x <- root_seq_poly (invariant_factors A)])>+1It now has the type:
forall (F : closedFieldType) (n : nat), 'M[F]_n -> 'M[F]_nThis is an improvement, but not complete, since the proof the diagonalization theorem still relies on the previous form (kept under the name
pre_Jordan_form).