Open
Conversation
Contributor
|
I am not triggering a CI run on this PR because the CI configuration has been modified. CI can be triggered manually by an authorized contributor. |
Contributor
|
@coqbot run full ci |
Contributor
|
Doesn't seem to work |
Contributor
|
Seems like a conflict with #21611 removing |
Contributor
|
Thanks for the hint. I’ll apply the patch. And we’ll discover the next issue… |
Contributor
|
some module issue in extraction |
now that the extraction problems are fixed
b21311b to
5dcd833
Compare
Contributor
|
I am not triggering a CI run on this PR because the CI configuration has been modified. CI can be triggered manually by an authorized contributor. |
Contributor
|
I’ve open an issue regarding the extraction issue: #21754 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jasmin was removed from CI in #20589 following changes in mathcomp (math-comp/math-comp#1256) that made the extraction to OCaml fail (see jasmin-lang/jasmin#1093 for the discussion).
We spent some time to make Jasmin (jasmin-lang/jasmin#1372) and its dependency coqword (jasmin-lang/coqword#37) avoid referencing the ring structures of mathcomp in the parts of Jasmin that are extracted (which were the reason of the failed extraction). Now that the changes are merged, extraction works again (we tested it with mathcomp 2.5, hopefully it works also with master), and I hope Jasmin can be enabled back in the CI.