-
Notifications
You must be signed in to change notification settings - Fork 217
fix __scanCodes is not defined and upgrade libs to work with react-native 0.71.2 #127
base: master
Are you sure you want to change the base?
Conversation
I also patched react-native-vision-camera (2.15.4) to work with the latest version of react-native (0.71.2) diff --git a/node_modules/react-native-vision-camera/android/build.gradle b/node_modules/react-native-vision-camera/android/build.gradle
index 91e64d9..a76e3c0 100644
--- a/node_modules/react-native-vision-camera/android/build.gradle
+++ b/node_modules/react-native-vision-camera/android/build.gradle
@@ -79,7 +79,7 @@ buildscript {
}
dependencies {
- classpath 'com.android.tools.build:gradle:4.2.2'
+ classpath("com.android.tools.build:gradle:7.3.1")
classpath 'de.undercouch:gradle-download-task:4.1.2'
// noinspection DifferentKotlinGradleVersion
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
diff --git a/node_modules/react-native-vision-camera/android/gradle.properties b/node_modules/react-native-vision-camera/android/gradle.properties
index d171611..a61e78e 100644
--- a/node_modules/react-native-vision-camera/android/gradle.properties
+++ b/node_modules/react-native-vision-camera/android/gradle.properties
@@ -11,10 +11,10 @@
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
# org.gradle.parallel=true
#Fri Feb 19 20:46:14 CET 2021
-VisionCamera_buildToolsVersion=30.0.0
-VisionCamera_compileSdkVersion=31
-VisionCamera_kotlinVersion=1.5.30
-VisionCamera_targetSdkVersion=31
-VisionCamera_ndkVersion=21.4.7075529
+VisionCamera_buildToolsVersion=33.0.0
+VisionCamera_compileSdkVersion=33
+VisionCamera_kotlinVersion=1.6.20
+VisionCamera_targetSdkVersion=33
+VisionCamera_ndkVersion=23.1.7779620
android.enableJetifier=true
android.useAndroidX=true
|
What is the ETA on this fix? |
@EstebanFuentealba I am experiencing an issue with building with the We are getting this error, which loops 100 times:
A fresh project will run with the latest React Native, the latest The syntax babel.config.js plugin may have something to do with it as well. I cant be sure just yet. |
Solved my problem! |
This works for me too. Any chance it can be merged?
|
@EstebanFuentealba much appreciated. I created a working example based on your changes. |
When can this be merged? |
…work with react-native 0.71.2
I updated the packages to work with the latest version of react-native (0.71.2) and the latest version of react-native-vision-camera (2.15.4).
Also fixed the problem of
__scanCodes is not defined
which closes issues #121 #112 #107 #106