Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

chore: update mlkit and react-native-vision-camera dependencies #58

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nachozullo
Copy link

Hello @rodgomesc,

We are currently working with this library in our app. Since the last update from one of our local dependency, which use the latest version of com.google.mlkit:barcode-scanning, the vision-camera-code-scanner library is not working on Android because the path where Barcode reference is located are different between versions.

In this PR I change all Barcode references and update the com.google.mlkit:barcode-scanning dependency. After that all start working again. I think that this is maybe a breaking change if you are using another library with com.google.mlkit:barcode-scanning as a dependency with a minor version but I tested and all appear to be working well.

Best regards.

@unfernandito
Copy link

nice @nachozullo this PR looks so well, i'll try late cause we have the same problem in our app.

Thanks

package.json Outdated Show resolved Hide resolved
@rodgomesc
Copy link
Owner

Hi @nachozullo, thanks for this PR and time invested in the project, i'm surprised that this project is working for you guys, i checked that PR and i'm facing the same issue that i had in master, that seems to be related to the reanimated lib, the app just crash instantly

Screen Shot 2022-04-15 at 10 55 59

@unfernandito
Copy link

Hello @rodgomesc look like the example from the main repo it's broken, i'll be try to fix it in this PR.

image

@unfernandito
Copy link

also fail in iOS

image

looks like a problem from the main repo :/

@rodgomesc
Copy link
Owner

@nachozullo you was able to successfully build the example app in this repo?

@tcank
Copy link

tcank commented Jun 1, 2022

Hi everyone. In our team we need this changes too. I checked and the example app crashes before @nachozullo changes.

There is a pull request to fix that #66, but it will be great to merge this PR asap.

Thanks for the library and the fix!

@mateosilguero
Copy link

@rodgomesc Would you merge this ? Otherwise i should patch this lib

@jorgebrunetto
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants