Skip to content

feat: add semantic multi-container C3 - #70

Merged
rodri-oliveira-dev merged 74 commits into
mainfrom
phase/09-semantic-c3
Oct 5, 2026
Merged

rodri-oliveira-dev merged 74 commits into
mainfrom
phase/09-semantic-c3

Conversation

@rodri-oliveira-dev

Copy link
Copy Markdown
Owner

Summary

This PR completes Phase 9 and evolves selective C3 from generic evidence groupings into bounded, evidence-first Semantic C3 for .NET, while preserving the existing C1/C2 contract and single-container behavior.

Semantic C3

  • persists bounded structural C# facts with stable project/symbol identity;
  • proposes responsibility-level HTTP/application, worker/consumer, messaging, persistence and integration components only when structural evidence supports them;
  • keeps component boundaries reviewable and carries navigable provenance;
  • composes internal relations with an explicit confidence policy: supported wiring + static invocation can confirm supported flows; name similarity, package presence and ProjectReference alone never confirm runtime edges;
  • emits semantic-c3-evidence-report.md with signals, missing signals, review reasons and bounded diagnostics.

Multi-container generation

  • CLI accepts repeated --c3-container values;
  • Core builds one canonical C3 workspace over the same reviewed C2 model/snapshot;
  • one model.c4 and one c3.views.c4 contain deterministic views for every selected container;
  • duplicate selections are canonicalized and argument order does not affect output;
  • invalid/non-container IDs and C3 on C1 fail before managed output is written;
  • legacy single-container generation remains compatible.

MCP and Agent

  • MCP exposes bounded c3Containers while preserving legacy c3ContainerId;
  • canonical inspected semantic facts stay private to the MCP session and cannot be fabricated by the model/client;
  • Agent repeated --c3-container values form an authorization allow-list and only an explicitly requested evidence-supported subset is forwarded;
  • selected C3 IDs are preserved through dry-run, validation/correction and destination-specific HITL write approval.

Dogfooding and validation

  • golden fixture is derived from dotnet-observability-lab responsibilities;
  • validates four C3 views in one workspace: Ingestion API, Outbox Worker, Consolidation API and Consolidation Worker;
  • distinguishes HTTP/application/persistence, worker/publisher, consumer/application processing and supported PostgreSQL/Redis/RabbitMQ integrations without promoting utility classes or inventing Redis for Consolidation Worker;
  • managed regeneration is deterministic and official LikeC4 validation passes;
  • CLI/MCP/Agent deterministic E2E coverage is included.

Branch CI: https://github.com/rodri-oliveira-dev/Repo2C4/actions/runs/37117887114

  • locked restore, format and Release build: pass
  • tests: 407/407 pass (including LikeC4 integration pass)
  • coverage: pass
  • official LikeC4 validation: pass
  • CLI offline multi-C3 dogfood + managed regeneration: pass
  • MCP/Agent deterministic E2E: pass
  • isolated CLI/MCP/Agent package install: pass
  • governance, LF line endings and clean worktree: pass

No release/version bump and no auto-merge are included.

Closes #62
Closes #63
Closes #64
Closes #65
Closes #66
Closes #67
Closes #68
Closes #69
Closes #61

@rodri-oliveira-dev rodri-oliveira-dev linked an issue Oct 3, 2026 that may be closed by this pull request
26 tasks done
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a21c7e9b70

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@rodri-oliveira-dev
rodri-oliveira-dev merged commit 3bd413d into main Oct 5, 2026
9 checks passed
@rodri-oliveira-dev
rodri-oliveira-dev deleted the phase/09-semantic-c3 branch October 5, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment