swift send implementation - #223
Merged
Merged
Conversation
|
@Wilfred007 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've successfully improved the mobile navigation experience. Here's what was implemented:
Changes Made
BottomNav Component Improvements
Larger touch targets: Increased to 64x64px minimum (exceeds 44px mobile standard)
Better spacing: Improved padding and gap for easier tapping
Haptic feedback: Added navigator.vibrate(10) on tap for tactile feedback
Active state animations: Added scale-95 on press and scale-110 for active items
Enhanced visual feedback:
Active items now have bg-primary/10 background
Hover states with hover:bg-accent/50
Active indicator moved to top-right corner
Backdrop blur: Added backdrop-blur-lg for better visual separation
Improved focus states: Better keyboard navigation with ring offsets
Page Updates
History page: Added missing BottomNav component and standardized padding to pb-24
SendMoney page: Standardized padding from pb-32 to pb-24 for consistency
Refunds page: Added missing BottomNav component and pb-24 padding
Consistent Mobile Spacing
All main pages now use pb-24 to ensure content doesn't overlap with bottom navigation
This provides 6rem (96px) of bottom padding, sufficient for the navigation bar
Closes #162
Closes #158
Closes #161
Closes #160