Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply cs fixes #80

Merged
merged 1 commit into from
Jun 5, 2024
Merged

apply cs fixes #80

merged 1 commit into from
Jun 5, 2024

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Mar 15, 2024

No description provided.

@dbu
Copy link
Contributor Author

dbu commented Mar 15, 2024

and now phpstan complains 🤦‍♂️

will look into this some more on monday.

@chregu
Copy link
Contributor

chregu commented Mar 15, 2024

Yup. Had the same issue ;) And couldn't fix it, but didn't try hard ennough.

And thanks for looking into it.

@dbu
Copy link
Contributor Author

dbu commented May 16, 2024

"next monday" is the new "next tuesday". but looked into it now and fixed the phpstan issues.

the part about marking types with ? when they default to null is relevant for PHP 8.4. that will do deprecation warnings for non nullable types that default to null.

src/Image.php Show resolved Hide resolved
src/UriHelper.php Outdated Show resolved Hide resolved
Copy link
Contributor

@thePanz thePanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, we should adapt the changes

@dbu dbu merged commit 79aa5e5 into master Jun 5, 2024
8 checks passed
@dbu dbu deleted the cs branch June 5, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants