Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#628] Clean up stored auth tokens #627

Open
wants to merge 58 commits into
base: develop
Choose a base branch
from

Conversation

roberlander2
Copy link
Contributor

@roberlander2 roberlander2 commented Jan 3, 2023

Description

This PR encrypts OIDC refresh tokens and hashes Core BB refresh tokens in login session documents. A <sessionID>: prefix has been added to Core BB refresh tokens sent in login and refresh responses, and OIDC refresh tokens are no longer sent in login and refresh responses. It also implements a session ID cache to rate limit refresh attempts for session IDs known to fail a refresh.
Depends on rokwire/core-auth-library-go#86.

Resolves: #628

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@roberlander2 roberlander2 self-assigned this Jan 3, 2023
utils/utils.go Fixed Show fixed Hide fixed
utils/utils.go Fixed Show fixed Hide fixed
@roberlander2 roberlander2 requested a review from shurwit February 7, 2023 22:46
shurwit
shurwit previously approved these changes Feb 10, 2023
Copy link
Collaborator

@shurwit shurwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roberlander2, LGTM!

@petyos, please take a look when you get a chance. Thanks!

@roberlander2 roberlander2 requested a review from shurwit February 23, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Clean up stored auth tokens
2 participants