Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#659] WebAuthn authentication #662

Open
wants to merge 38 commits into
base: develop
Choose a base branch
from
Open

[#659] WebAuthn authentication #662

wants to merge 38 commits into from

Conversation

shurwit
Copy link
Collaborator

@shurwit shurwit commented May 11, 2023

Description

Please provide a summary of the pull request and the issue it resolves. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Resolves #659

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

shurwit and others added 26 commits July 1, 2022 15:51
@shurwit
add app-env.json and update port
5011662
@shurwit
Merge pull request #1 from rokwire/develop
2d9a21e 
Update develop
@shurwit
Update app-env.json
95a9dcc
@shurwit
Update app-env.json
6c7a0fe
@shurwit
update detect-secrets, update secrets baseline
a11f0e8
@shurwit
Merge branch 'develop' of github.com:rokwire/core-building-block into…
1d2508d 
… rokwire-develop
@shurwit
Merge branch 'rokwire-develop' into develop
7d057ef
@shurwit
update secrets baseline
39bdf91
@shurwit
Merge pull request #2 from rokmetro/develop
ed5b051 
Update main
@shurwit
Merge branch 'develop' of github.com:rokwire/core-building-block into…
6fb9742 
… rokwire-develop
@shurwit
Merge branch 'rokwire-develop' into develop
c72fd75
@shurwit
Merge branch 'rokwire:develop' into develop
5de2456
@shurwit
update makefile versioning
1c2fec8
@shurwit
Merge branch 'develop' of https://github.com/rokmetro/core-building-b…
6e5e584 
…lock-fork into develop
@shurwit
Update Makefile
73d1b16 
Fix typo
@shurwit
print version
2ea332a
@shurwit
upgrade go to v1.20
65d9a09
@shurwit
Merge remote-tracking branch 'rokwire/develop' into develop
fd50583
@shurwit
fix secrets
c0f0e6c
@shurwit
Merge branch 'main' into develop
8b7065a
@shurwit
initial webauthn implementation (in progress)
88e9f27
@shurwit
Merge remote-tracking branch 'origin/develop' into 659-webauthn-authe…
7b82b03 
…ntication
@shurwit
refactor webauthn to handle credentials, update docs
d8d3355
@shurwit
avoid creating inaccessible accounts
325739d
@shurwit
fix webauthn registration issues, add webauthn test page
7decc84
@shurwit
fix webauthn login flow
e20aac5
@shurwit shurwit requested a review from petyos as a code owner May 11, 2023 17:24
@shurwit shurwit linked an issue May 11, 2023 that may be closed by this pull request
[FEATURE] WebAuthn authentication #659
Open
@shurwit shurwit requested a review from roberlander2 May 11, 2023 17:30
shurwit and others added 2 commits May 11, 2023 13:33
@shurwit
Merge remote-tracking branch 'rokwire/develop' into develop
85929cc
@shurwit
[#659] WebAuthn authentication (#7)
9826b5e 
* initial webauthn implementation (in progress)

* refactor webauthn to handle credentials, update docs

* avoid creating inaccessible accounts

* fix webauthn registration issues, add webauthn test page

* fix webauthn login flow

* update changelog
roberlander2
roberlander2 requested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@roberlander2 roberlander2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shurwit, this looks good! I just left a few minor questions below.

driver/web/adapter.go Show resolved Hide resolved
core/auth/auth_type_webauthn.go Outdated Show resolved Hide resolved
core/auth/auth_type_webauthn.go Outdated Show resolved Hide resolved
@shurwit shurwit requested a review from roberlander2 May 17, 2023 19:36
roberlander2
roberlander2 previously approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@roberlander2 roberlander2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shurwit, LGTM!

shurwit and others added 6 commits June 9, 2023 09:42
@shurwit
Merge branch 'develop' into 659-webauthn-authentication
73fe777
@shurwit
[#659] webauthn authentication (#8)
e6b1597 
* initial webauthn implementation (in progress)

* refactor webauthn to handle credentials, update docs

* avoid creating inaccessible accounts

* fix webauthn registration issues, add webauthn test page

* fix webauthn login flow

* update changelog

* fix error handling

* fix login issues for mobile

* upgrade dependencies
@roberlander2
add webauthn to account check types
233ea82
@roberlander2
Merge branch 'develop' into 659-webauthn-authentication
34c937f
@shurwit
add configs for authenticator selection to supported auth type params
f698e2b
@roberlander2
merged changes from develop
d1f5e75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberlander2 roberlander2 roberlander2 left review comments

@petyos petyos Awaiting requested review from petyos petyos is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] WebAuthn authentication
2 participants
@shurwit @roberlander2