Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "code" field #681

Merged
merged 29 commits into from
Nov 24, 2023
Merged

Add "code" field #681

merged 29 commits into from
Nov 24, 2023

Conversation

stefanvit
Copy link
Collaborator

Description

Add "code" field

**Resolves

Review Time Estimate

  • Immediately
  • Within a week
  • When possible

Type of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@stefanvit stefanvit requested a review from petyos November 22, 2023 07:12
@stefanvit stefanvit requested a review from shurwit as a code owner November 22, 2023 07:12
petyos
petyos requested changes Nov 24, 2023
View reviewed changes
driver/web/conversions_application.go Outdated Show resolved Hide resolved
driver/web/docs/gen/def.yaml Outdated Show resolved Hide resolved
driver/web/docs/gen/def.yaml Outdated Show resolved Hide resolved
driver/web/docs/gen/gen_types.go Outdated Show resolved Hide resolved
go.mod Outdated
@@ -40,50 +40,101 @@ require (
)

require (
github.com/BurntSushi/toml v1.3.2 // indirect
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You issue does not suppose any changes in the dependencies, so go.mod and go.sum should not be modified.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was generated from go.mod

@stefanvit stefanvit requested a review from petyos November 24, 2023 08:30
@petyos petyos merged commit 1edafb4 into 680-task-single-identity-within-the-whole-ecosystem Nov 24, 2023
1 check passed
@petyos petyos deleted the add-code branch November 24, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shurwit shurwit Awaiting requested review from shurwit

@petyos petyos Awaiting requested review from petyos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanvit @petyos