ROKMETRO Updates #707

roberlander2 · 2024-03-07T22:59:22Z

Description

This PR merges in updates from the ROKMETRO team, which includes WebAuthn authentication, a split of existing AccountAuthType data into AccountAuthType and AccountIdentifier to allow users to authenticate with any identifier/auth type combination, account following support, app org token duration policies, and various bug fixes and logging improvements.

All of these changes should be backwards compatible with existing client applications and existing building blocks. This is a combination of many different changes, so please let me know if you notice any issues or have questions or concerns. Thanks!

Resolves #659, #677, #472, #674

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

Immediately
Within a week
When possible

Type of changes

Please select a relevant option:

Bug fix (non-breaking change which fixes an issue).
New feature (non-breaking change which adds functionality).
Breaking change (fix or feature that would cause existing functionality to not work as expected).
Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

* add app-env.json and update port * Update app-env.json * Update app-env.json * update detect-secrets, update secrets baseline * update secrets baseline * update makefile versioning * Update Makefile Fix typo * print version * upgrade go to v1.20 * fix secrets * initial webauthn implementation (in progress) * refactor webauthn to handle credentials, update docs * avoid creating inaccessible accounts * fix webauthn registration issues, add webauthn test page * fix webauthn login flow * update changelog * [rokwire#659] WebAuthn authentication (#7) * initial webauthn implementation (in progress) * refactor webauthn to handle credentials, update docs * avoid creating inaccessible accounts * fix webauthn registration issues, add webauthn test page * fix webauthn login flow * update changelog * fix error handling * fix login issues for mobile * upgrade dependencies * [rokwire#659] webauthn authentication (#8) * initial webauthn implementation (in progress) * refactor webauthn to handle credentials, update docs * avoid creating inaccessible accounts * fix webauthn registration issues, add webauthn test page * fix webauthn login flow * update changelog * fix error handling * fix login issues for mobile * upgrade dependencies * add webauthn to account check types * add configs for authenticator selection to supported auth type params * add configs for authenticator selection to supported auth type params (#10) * start adding verification types (contains errors) [rokwire#665] * continue splitting auth and verification types [rokwire#665] * finish implementing password auth type, start code verification type, add phone verifier interface [rokwire#665] * finish refactoring identifier, auth types, start updating apis [rokwire#665] * upgrade dependencies * finish fixing errors [rokwire#665] * fix passkey errors [rokwire#665] * bug fixes, email with passkey not working because no params in email auth type * update identifier impl and auth impl getters to better handle backwards compatibility (has errors) * bug fixes, email and passkey not completing registration * add json omitempty tags to credential structs * better identifier type parsing * passkeys using email and username identifiers working * start fixing phone, passkey auth * bug fixes for phone and passkey, better error messages * simplify phone verifier interface * phone auth type link working, add authCommunicationChannel interface to handle verification functions * add ability to link webauthn credentials to accounts * only set username if empty * Change messages handling for verification * remove commented blocks * cleanup * return verified auth types when cannot find account with username but not identifier * bug fixes * fix phone auth type docs * make sure usernames are lowercase, do not fail if phone verifier fails to init * start refactoring account auth types into account auth types and account identifiers, do not store identifiers in credentials (contains errors) * more progress, identifier type and auth type simplifications * read email verification settings from config, refactor verify credential APIs to verify identifier * build error fixes, add account identifier storage operations * start preparing for multiple credentials of same type (e.g., passkeys) * some progress implementing passkey with identifier flow * rewrite passkey flows * build error cleanup, start moving account external IDs into identifiers, refactor shared profile stuff * start fixing shared profiles * comment shared profile functionality * update API docs for linking auth types and identifiers, more error fixes * more API doc tweaks, more error fixes, remove all uses of claims.UID * more link and unlink request body tweaks * do not store account auth type ID in login session, instead use identifier to get account * start working on link account auth type implementation updates * more link auth type updates * finish implementing link identifier, some code auth type bug fixes * match LinkAccountIdentifier interface definition * fix remaining build errors, begin implementing DB migration * add support for login using external identifiers, update more request body definitions * identifiers bug fixes, fix build errors * update db indexes * start implementing db migration * do not allow generic oidc auth type code - no specified identity provider * implement app org and auth type migrations * credentials migration working, use json convert utils func * login session migration done * accounts migration done, a few bug fixes related to external IDs * move migration functions into separate file * more bug fixes, accountAuthTypesToDef not working * email and phone login fixes, finish implementing identifier-less login * bug fixes * linking, unlinking bug fixes * more linking, unlinking bug fixes and identifier verification email bug fixes * username login, webauthn backwards compatible login bug fixes * fix identifier-less webauthn login, update canLink * fix passkey sign up * return account on webauthn signup * make OIDC ID tokens optional * add sign-in-options API, update login API to accept account identifier ID * finish implementing sign in options and login with identifier ID * mask email and phone identifiers for sign in options, add regexp to validate emails * clean up linking, unlinking * fix unlink examples, sign in options fix, handle nil identifier when linking * upgrade dependencies, set username in token claims * use error statuses for auth type and identifier linking * allow webauthn credentials to be created after account already exists * update changelog * updates and fixes for conde_oidc, started refactoring email and phone from profile, username from account into identifiers * fix build errors * start handling external email identifiers * implement profile email and phone and account username migrations * set sensitive flags for email and phone migrations * finish implementing identifier sensitive field, return profile email, phone and username for BC * disallow updating account username to empty string * add sensitive field to account identifier api model * bug fixes * mark email as external if it matches external email field * usernames verified by default, identifiers used to sign up with webauthn unverified by default * auth type unlink bug fixes * simplify link auth type transaction, add app type identifier to webauthn aat params * fix link docs example * return identifiers on auth type link and unlink * improve external identifier migration, add IsEmailVerified flag * do not change email sensitivity on update external identifiers * remove API docs comment * fix go mod --------- Co-authored-by: Stephen Hurwit <[email protected]> Co-authored-by: Stephen Hurwit <[email protected]> Co-authored-by: akshadpai <[email protected]>

* add app-env.json and update port * Update app-env.json * Update app-env.json * update detect-secrets, update secrets baseline * update secrets baseline * update makefile versioning * Update Makefile Fix typo * print version * upgrade go to v1.20 * fix secrets * initial webauthn implementation (in progress) * refactor webauthn to handle credentials, update docs * avoid creating inaccessible accounts * fix webauthn registration issues, add webauthn test page * fix webauthn login flow * update changelog * [rokwire#659] WebAuthn authentication (#7) * initial webauthn implementation (in progress) * refactor webauthn to handle credentials, update docs * avoid creating inaccessible accounts * fix webauthn registration issues, add webauthn test page * fix webauthn login flow * update changelog * fix error handling * fix login issues for mobile * upgrade dependencies * [rokwire#659] webauthn authentication (#8) * initial webauthn implementation (in progress) * refactor webauthn to handle credentials, update docs * avoid creating inaccessible accounts * fix webauthn registration issues, add webauthn test page * fix webauthn login flow * update changelog * fix error handling * fix login issues for mobile * upgrade dependencies * add webauthn to account check types * add configs for authenticator selection to supported auth type params * add configs for authenticator selection to supported auth type params (#10) * start adding verification types (contains errors) [rokwire#665] * continue splitting auth and verification types [rokwire#665] * finish implementing password auth type, start code verification type, add phone verifier interface [rokwire#665] * finish refactoring identifier, auth types, start updating apis [rokwire#665] * upgrade dependencies * finish fixing errors [rokwire#665] * fix passkey errors [rokwire#665] * bug fixes, email with passkey not working because no params in email auth type * update identifier impl and auth impl getters to better handle backwards compatibility (has errors) * bug fixes, email and passkey not completing registration * add json omitempty tags to credential structs * better identifier type parsing * passkeys using email and username identifiers working * start fixing phone, passkey auth * bug fixes for phone and passkey, better error messages * simplify phone verifier interface * phone auth type link working, add authCommunicationChannel interface to handle verification functions * add ability to link webauthn credentials to accounts * only set username if empty * Change messages handling for verification * remove commented blocks * cleanup * return verified auth types when cannot find account with username but not identifier * bug fixes * fix phone auth type docs * make sure usernames are lowercase, do not fail if phone verifier fails to init * start refactoring account auth types into account auth types and account identifiers, do not store identifiers in credentials (contains errors) * more progress, identifier type and auth type simplifications * read email verification settings from config, refactor verify credential APIs to verify identifier * build error fixes, add account identifier storage operations * start preparing for multiple credentials of same type (e.g., passkeys) * some progress implementing passkey with identifier flow * rewrite passkey flows * build error cleanup, start moving account external IDs into identifiers, refactor shared profile stuff * start fixing shared profiles * comment shared profile functionality * update API docs for linking auth types and identifiers, more error fixes * more API doc tweaks, more error fixes, remove all uses of claims.UID * more link and unlink request body tweaks * do not store account auth type ID in login session, instead use identifier to get account * start working on link account auth type implementation updates * more link auth type updates * finish implementing link identifier, some code auth type bug fixes * match LinkAccountIdentifier interface definition * fix remaining build errors, begin implementing DB migration * add support for login using external identifiers, update more request body definitions * identifiers bug fixes, fix build errors * update db indexes * start implementing db migration * do not allow generic oidc auth type code - no specified identity provider * implement app org and auth type migrations * credentials migration working, use json convert utils func * login session migration done * accounts migration done, a few bug fixes related to external IDs * move migration functions into separate file * more bug fixes, accountAuthTypesToDef not working * email and phone login fixes, finish implementing identifier-less login * bug fixes * linking, unlinking bug fixes * more linking, unlinking bug fixes and identifier verification email bug fixes * username login, webauthn backwards compatible login bug fixes * fix identifier-less webauthn login, update canLink * fix passkey sign up * return account on webauthn signup * make OIDC ID tokens optional * add sign-in-options API, update login API to accept account identifier ID * finish implementing sign in options and login with identifier ID * mask email and phone identifiers for sign in options, add regexp to validate emails * clean up linking, unlinking * fix unlink examples, sign in options fix, handle nil identifier when linking * upgrade dependencies, set username in token claims * use error statuses for auth type and identifier linking * allow webauthn credentials to be created after account already exists * update changelog * updates and fixes for conde_oidc, started refactoring email and phone from profile, username from account into identifiers * fix build errors * start handling external email identifiers * implement profile email and phone and account username migrations * set sensitive flags for email and phone migrations * finish implementing identifier sensitive field, return profile email, phone and username for BC * disallow updating account username to empty string * add sensitive field to account identifier api model * bug fixes * mark email as external if it matches external email field * usernames verified by default, identifiers used to sign up with webauthn unverified by default * auth type unlink bug fixes * simplify link auth type transaction, add app type identifier to webauthn aat params * fix link docs example * return identifiers on auth type link and unlink * improve external identifier migration, add IsEmailVerified flag * do not change email sensitivity on update external identifiers * remove API docs comment * fix go mod * fix webauthn beginLogin with identifier (missing user.Name) --------- Co-authored-by: Stephen Hurwit <[email protected]> Co-authored-by: Stephen Hurwit <[email protected]> Co-authored-by: akshadpai <[email protected]>

* start implementing account secrets - added to core and API models, added encryption, decryption utils [rokwire#677] * implement service AES key management [rokwire#677] * update mock storage [rokwire#677] * add update secrets API, add decrypt secrets func to auth interface [rokwire#677] * add missing files * implement secrets decryption on get account and login [rokwire#677] * bug fixes and cleanup, add timestamp fields to key model (RSA-PSS parsing not working) [rokwire#677] * update changelog

* add app-env.json and update port * Update app-env.json * Update app-env.json * update detect-secrets, update secrets baseline * update secrets baseline * update makefile versioning * Update Makefile Fix typo * print version * upgrade go to v1.20 * fix secrets * initial webauthn implementation (in progress) * refactor webauthn to handle credentials, update docs * avoid creating inaccessible accounts * fix webauthn registration issues, add webauthn test page * fix webauthn login flow * update changelog * [rokwire#659] WebAuthn authentication (#7) * initial webauthn implementation (in progress) * refactor webauthn to handle credentials, update docs * avoid creating inaccessible accounts * fix webauthn registration issues, add webauthn test page * fix webauthn login flow * update changelog * fix error handling * fix login issues for mobile * upgrade dependencies * [rokwire#659] webauthn authentication (#8) * initial webauthn implementation (in progress) * refactor webauthn to handle credentials, update docs * avoid creating inaccessible accounts * fix webauthn registration issues, add webauthn test page * fix webauthn login flow * update changelog * fix error handling * fix login issues for mobile * upgrade dependencies * add webauthn to account check types * add configs for authenticator selection to supported auth type params * add configs for authenticator selection to supported auth type params (#10) * start adding verification types (contains errors) [rokwire#665] * continue splitting auth and verification types [rokwire#665] * finish implementing password auth type, start code verification type, add phone verifier interface [rokwire#665] * finish refactoring identifier, auth types, start updating apis [rokwire#665] * upgrade dependencies * finish fixing errors [rokwire#665] * fix passkey errors [rokwire#665] * bug fixes, email with passkey not working because no params in email auth type * update identifier impl and auth impl getters to better handle backwards compatibility (has errors) * bug fixes, email and passkey not completing registration * add json omitempty tags to credential structs * better identifier type parsing * passkeys using email and username identifiers working * start fixing phone, passkey auth * bug fixes for phone and passkey, better error messages * simplify phone verifier interface * phone auth type link working, add authCommunicationChannel interface to handle verification functions * add ability to link webauthn credentials to accounts * only set username if empty * Change messages handling for verification * remove commented blocks * cleanup * return verified auth types when cannot find account with username but not identifier * bug fixes * fix phone auth type docs * make sure usernames are lowercase, do not fail if phone verifier fails to init * start refactoring account auth types into account auth types and account identifiers, do not store identifiers in credentials (contains errors) * more progress, identifier type and auth type simplifications * read email verification settings from config, refactor verify credential APIs to verify identifier * build error fixes, add account identifier storage operations * start preparing for multiple credentials of same type (e.g., passkeys) * some progress implementing passkey with identifier flow * rewrite passkey flows * build error cleanup, start moving account external IDs into identifiers, refactor shared profile stuff * start fixing shared profiles * comment shared profile functionality * update API docs for linking auth types and identifiers, more error fixes * more API doc tweaks, more error fixes, remove all uses of claims.UID * more link and unlink request body tweaks * do not store account auth type ID in login session, instead use identifier to get account * start working on link account auth type implementation updates * more link auth type updates * finish implementing link identifier, some code auth type bug fixes * match LinkAccountIdentifier interface definition * fix remaining build errors, begin implementing DB migration * add support for login using external identifiers, update more request body definitions * identifiers bug fixes, fix build errors * update db indexes * start implementing db migration * do not allow generic oidc auth type code - no specified identity provider * implement app org and auth type migrations * credentials migration working, use json convert utils func * login session migration done * accounts migration done, a few bug fixes related to external IDs * move migration functions into separate file * more bug fixes, accountAuthTypesToDef not working * email and phone login fixes, finish implementing identifier-less login * bug fixes * linking, unlinking bug fixes * more linking, unlinking bug fixes and identifier verification email bug fixes * username login, webauthn backwards compatible login bug fixes * fix identifier-less webauthn login, update canLink * fix passkey sign up * return account on webauthn signup * make OIDC ID tokens optional * add sign-in-options API, update login API to accept account identifier ID * finish implementing sign in options and login with identifier ID * mask email and phone identifiers for sign in options, add regexp to validate emails * clean up linking, unlinking * fix unlink examples, sign in options fix, handle nil identifier when linking * upgrade dependencies, set username in token claims * use error statuses for auth type and identifier linking * allow webauthn credentials to be created after account already exists * update changelog * updates and fixes for conde_oidc, started refactoring email and phone from profile, username from account into identifiers * fix build errors * start handling external email identifiers * implement profile email and phone and account username migrations * set sensitive flags for email and phone migrations * finish implementing identifier sensitive field, return profile email, phone and username for BC * disallow updating account username to empty string * add sensitive field to account identifier api model * bug fixes * mark email as external if it matches external email field * usernames verified by default, identifiers used to sign up with webauthn unverified by default * auth type unlink bug fixes * simplify link auth type transaction, add app type identifier to webauthn aat params * fix link docs example * return identifiers on auth type link and unlink * improve external identifier migration, add IsEmailVerified flag * do not change email sensitivity on update external identifiers * remove API docs comment * fix go mod * fix webauthn beginLogin with identifier (missing user.Name) * move phone and email validation to utils, validate profile phone and email on account migration * delete login states once used successfully, fix email and code login * add context to UpdateCredentialValue storage function * merged changes from rokwire-674 --------- Co-authored-by: Stephen Hurwit <[email protected]> Co-authored-by: Stephen Hurwit <[email protected]> Co-authored-by: akshadpai <[email protected]>

…se identifiers in account search API examples

… in auth

…f accounts coll

…in sessions

…during auth type migration

…equestor is not scoped for identifiers

petyos

Thanks @roberlander2 The review is in progress.

It is a huge PR and it will take time until I pass through it. I noticed two issues and marked them in the code lines. Thanks

petyos · 2024-03-11T08:35:07Z

driven/storage/model_application.go

@@ -23,9 +23,8 @@ type application struct {
 	ID   string `bson:"_id"`
 	Name string `bson:"name"`

-	MultiTenant bool   `bson:"multi_tenant"`
-	Admin       bool   `bson:"admin"`
-	Code        string `bson:"code"`


As I know the code field is used in the client apps so that the client to give more approariate UI name of the application but not the one in the name field. This was used in the events UI. I am not familiar with the client code but if not removed then maybe we still need this field.
cc @mihail-varbanov

Thanks for pointing this out @petyos. I looked through the client code for a bit and could not find where the Code field is used, but please let me know if it is still being used and I will undo this change.

I talked with @mihail-varbanov too. It seems this code using is no more used indeed. Thanks.

petyos · 2024-03-11T14:10:06Z

driven/storage/migrations.go

+	return nil
+}
+
+// migrate to tenants accounts


We already removed all this code for tenants accounts migration as it was deployed on all environments.

I added these changes for the migration back in to perform the migration in the ROKMETRO database. I realize I made a mistake in changing the "migrated_2" field name to "migrated", which would cause the migration to run again on accounts in the ROKWIRE database. I fixed this issue so that this migration that I re-introduced will not affect the already migrated ROKWIRE accounts.

Why don't we remove all this migration code related with the tenants accounts? Or this is not applied into the Rokmetro databases yet?

Yes, the tenant account migration has not yet been applied to the Rokmetro databases.

Hi @roberlander2. I understand but I think we should merge into the Rokwire code only the new stuff you have developed and changed but not old Rokwire code. In the latest code in Rokwire the tenant accounts migration code does not exist. It was removed with this issue #698 We had issues with the tenants accounts migration and we reverted the version the first time. Finally we fixed it and all now in Rokwire is working as expected and the migration code was removed. Maybe you should get the latest code state from Rokwire develop and merge into your branch. As you have not deployed this yet then maybe better to put this tenant migration code alive but only in the Rokmetro world not introducing it again in Rokwire with your PR. In addition to your huge PR including couple issues handled, some refactoring and your migration stuff, keeping also the tenants migration code complicates the transfer of your code into the Rokwire code and poses a risk for issues. Let me know if you have any comments. Thanks.

Thanks @petyos, I think you are right that we should not reintroduce the tenant accounts migration, so I removed it.

Thanks @roberlander2

petyos

Hi @roberlander2 ,

I am back on reviewing this. The review is in progress. I left two comments. Also, do we need to add (or update) any environment variables with these changes? Thanks.

main.go

petyos · 2024-04-02T13:06:21Z

main.go

-		alg = keys.RS256
-	}
-	authPrivKey, err := keys.NewPrivKey(alg, authPrivKeyPem)
+	oldSupportLegacySigsStr := envLoader.GetAndLogEnvVar("ROKWIRE_CORE_OLD_SUPPORT_LEGACY_SIGNATURES", false, false)


What is the difference between the new and the old legacy signatures?

The difference is to account for the potential to change from a RS256 key to a PS256 key. The legacy signature support is used in parsePrivKeyFromEnvVar to set the correct algorithm for both the old key and the new key.

roberlander2 · 2024-04-03T21:35:44Z

Hi @roberlander2 ,

I am back on reviewing this. The review is in progress. I left two comments. Also, do we need to add (or update) any environment variables with these changes? Thanks.

Thank you @petyos,

There are five new environment variables (listed below) and all are optional. The first two are used to set parameters that determine how verification emails are sent to users and the last three are used to support private key rotation for the service (we should only set them when we want to perform a rotation).

ROKWIRE_CORE_VERIFY_WAIT_TIME
ROKWIRE_CORE_VERIFY_EXPIRY
ROKWIRE_CORE_OLD_SUPPORT_LEGACY_SIGNATURES
ROKWIRE_CORE_OLD_AUTH_PRIV_KEY
ROKWIRE_CORE_OLD_AUTH_PRIV_KEY_PATH

…ne to be updated in identifiers

…allow beginRegistration for webauthn in checkCredentials

petyos · 2024-04-22T06:08:38Z

Hi @roberlander2 ,
I am back on reviewing this. The review is in progress. I left two comments. Also, do we need to add (or update) any environment variables with these changes? Thanks.

Thank you @petyos,

There are five new environment variables (listed below) and all are optional. The first two are used to set parameters that determine how verification emails are sent to users and the last three are used to support private key rotation for the service (we should only set them when we want to perform a rotation).
* ROKWIRE_CORE_VERIFY_WAIT_TIME

* ROKWIRE_CORE_VERIFY_EXPIRY

* ROKWIRE_CORE_OLD_SUPPORT_LEGACY_SIGNATURES

* ROKWIRE_CORE_OLD_AUTH_PRIV_KEY

* ROKWIRE_CORE_OLD_AUTH_PRIV_KEY_PATH

Ok, thanks!

roberlander2 · 2024-08-08T19:37:43Z

@roberlander2 remember to update rokmetro:rokwire-develop with changes from rokmetro:develop in addition to rokwire:develop.

roberlander2 and others added 30 commits October 6, 2023 15:25

add oidc request params field

334bbb1

fix format

69ff9c0

fix no credential migration

4f766d8

cache configs on insert

e68f866

fix migration issues

e69c66f

disable returning secrets

ae4628c

add redirect uri to database configs

10775b7

add auth request id

cfc6731

fix admin account credential parsing

61de3d1

add expose docs env var

1cd4694

fix redirect uri handling

bf31222

finished resolving merge conflicts, errors not yet fixed

d4b0b26

fix some build errors

6327157

fix remaining build errors

2dda19a

make default access token expiration configurable

3f73c86

resolves rokwire#472

f737aeb

remove UIUC specific pieces from migration

434431f

migration updates

7620651

remove phase2 from tenant account migration, change external_ids to u…

1d8c6f0

…se identifiers in account search API examples

use preferences on org signup external, remove unused function params…

bb26f88

… in auth

improve logging

fd35d96

upgrade auth library

0208566

more unused function param cleanup, use tenantAccounts coll instead o…

964d96a

…f accounts coll

batch credential collection migration, need to batch accounts and log…

65aa364

…in sessions

batch account identifiers migration

0246d4a

fix account and credential migration batching bugs

59009b2

roberlander2 added 9 commits March 5, 2024 15:16

merge changes from develop

18161ed

merge changes from rokwire/develop

c490552

update go version to 1.22

0cde308

update changelog, merge duplicate any tenant account app memberships …

1bd8451

…during auth type migration

fix bbs, tps, and admin account search by params

b45ab42

make sure account identifiers are not returned in account search if r…

4265838

…equestor is not scoped for identifiers

fix Account, PartialAccount schema validation bugs

3b19c8b

fix FindAccount bug when attempting operationAppSignUp

be0cb54

batch tenant account migration

42c5ea1

roberlander2 self-assigned this Mar 7, 2024

roberlander2 requested review from petyos and shurwit as code owners March 7, 2024 22:59

shurwit mentioned this pull request Mar 8, 2024

ROKMETRO Updates rokwire/app-flutter-plugin#437

Open

petyos reviewed Mar 11, 2024

View reviewed changes

roberlander2 added 2 commits March 11, 2024 14:22

change migrated field back to migrated_2 for tenant account migration

b4f7ec1

remove tenant account migration (already completed)

e8d3cc8

petyos reviewed Apr 2, 2024

View reviewed changes

roberlander2 added 5 commits April 3, 2024 17:41

bug fixes, upgrade dependencies

80fc4e0

add UseForProfile to account identifiers, allow profile email and pho…

6044cf9

…ne to be updated in identifiers

remove unnecessary nil check

63512cc

add limit for number of stored login states per app org user, do not …

8565f17

…allow beginRegistration for webauthn in checkCredentials

check for code account auth type in code auth

ffa3186

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ROKMETRO Updates #707

ROKMETRO Updates #707

roberlander2 commented Mar 7, 2024 •

edited

Loading

petyos left a comment

petyos Mar 11, 2024

roberlander2 Mar 11, 2024

petyos Mar 12, 2024

petyos Mar 11, 2024

roberlander2 Mar 11, 2024 •

edited

Loading

petyos Mar 12, 2024

roberlander2 Mar 12, 2024

petyos Mar 13, 2024

roberlander2 Mar 13, 2024

petyos Mar 15, 2024

petyos left a comment

petyos Apr 2, 2024

roberlander2 Apr 3, 2024 •

edited

Loading

roberlander2 commented Apr 3, 2024

petyos commented Apr 22, 2024

roberlander2 commented Aug 8, 2024

ROKMETRO Updates #707

Are you sure you want to change the base?

ROKMETRO Updates #707

Conversation

roberlander2 commented Mar 7, 2024 • edited Loading

Description

Review Time Estimate

Type of changes

Checklist:

petyos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

roberlander2 Mar 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petyos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

roberlander2 Apr 3, 2024 • edited Loading

Choose a reason for hiding this comment

roberlander2 commented Apr 3, 2024

petyos commented Apr 22, 2024

roberlander2 commented Aug 8, 2024

roberlander2 commented Mar 7, 2024 •

edited

Loading

roberlander2 Mar 11, 2024 •

edited

Loading

roberlander2 Apr 3, 2024 •

edited

Loading