Conversation
* add service accounts * add refresh service account token handler * start updating token management * finish updating service account endpoints * start adding system endpoints * updates to service account system endpoints * more updates to service account system endpoints * finish service account system endpoints * update changelog * add signature auth from auth library * continue adding signature auth for service account tokens * register service account and add service cred bug fixes * signature auth bug fixes * bugfixes * flag accounts for deletion, add get deleted accounts endpoint * updated changelog * add delete accounts timer * updated docs, service account storage model, implemented missing storage functions * add optional search params for get service accounts * bugfixes and improvements * remove system endpoints used for testing * don't delete accounts on get removed accounts * add delete accounts period env var, add bbs permissions auth * use profile pointer in account * improve get deleted accounts handler * removed commented code * added service account id to ServiceReg and AuthServiceReg * upgrade auth lib to 1.0.5 * upgrade auth lib to 1.0.5 * added bbs access-token endpoint * reverted account profile to use struct, updated docs * get deleted accounts by app_org_id * use all in tokens for null appIDs, orgIDs * updates for upcoming core-auth-library update [#335] * update service accounts and tokens to use all string [#335] * fix bbs permissions policy * fix secrets baseline * update go version, upgrade dependencies * change deleted flags to date_deleted timestamps, change BBs GET deleted-accounts API response to partial memberships * refactor bbs/deleted-accounts to bbs/deleted-memberships, improve response schema * add DeletedMembershipContext to send additional data to each service about which data to delete per deleted membership * bug fixes * upgrade dependencies * move deleted memberships to separate collection * bug fixes * add get_deleted-memberships bbs auth policy description * Do not fail if a context is not passed * Service id is not used * Filter by time - in progress * Filter by time - in progress * Fix mock * Filter by time - done * Do not delete the removed memberships for now - we allow filtering by date --------- Co-authored-by: Petyo Stoyanov <petyo.stoyanov@inabit.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a summary of the pull request and the issue it resolves. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.
Resolves #(add issue number here and remove parentheses)
Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.
Type of changes
Please select a relevant option:
Checklist:
Please select all applicable options: