Skip to content

Commit

Permalink
[ID-68] Fix the Webtools events import (#69)
Browse files Browse the repository at this point in the history
* Update CHANGELOG.md

* Do not use the transaction context

---------

Co-authored-by: Petyo Stoyanov <[email protected]>
  • Loading branch information
petyos and petyos authored Apr 8, 2024
1 parent a85c2ca commit 3606870
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Fix the Webtools events import [#68](https://github.com/rokwire/gateway-building-block/issues/68)

[2.4.2] - 2024-04-01
### Fixed
- Fix add to webtools blacklist [#65](https://github.com/rokwire/gateway-building-block/issues/65)
Expand Down
2 changes: 1 addition & 1 deletion core/logic_events.go
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ func (e eventsLogic) processWebToolsEvents() {
//in transaction
err = e.app.storage.PerformTransaction(func(context storage.TransactionContext) error {
//1. first find which events are already in the database. You have to compare by dataSourceEventId field.
legacyEventItemFromStorage, err := e.app.storage.FindLegacyEventItems(context)
legacyEventItemFromStorage, err := e.app.storage.FindLegacyEventItems(nil) //does not pass the transaction context - an issue!
if err != nil {
e.logger.Errorf("error on loading events from the storage - %s", err)
return nil
Expand Down

0 comments on commit 3606870

Please sign in to comment.