Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#103] add markers and highlites parameters to floorplans api #104

Merged

Conversation

clint156
Copy link
Collaborator

Description

Please provide a summary of the pull request and the issue it resolves. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.
Adds markers and highlites parameters to the floorplan end point as optional paramters. If set to "on" or omitted, markers and highlites from the campus api are displayed in the initial rendering of the floor plan. If set to "none", then they are hidden in the initial rendering.

**Resolves #103 **

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • [ x] Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • [x ] New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • [ x] I have updated the CHANGELOG.
  • [ x] I have read the Contributor Guidelines.
  • [ x] I have performed a self-review of my own code.
  • [x ] I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@clint156 clint156 linked an issue Jun 28, 2024 that may be closed by this pull request
@clint156 clint156 closed this Jun 28, 2024
@clint156 clint156 reopened this Jun 28, 2024
@clint156 clint156 merged commit 24951a6 into develop Jun 28, 2024
2 checks passed
@clint156 clint156 deleted the 103-feature-inmplement-floor-plan-toggle-parameter branch June 28, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Inmplement floor plan toggle parameter
1 participant