Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33 bug coordinates for some buildings are rounding #34

Merged

Conversation

clint156
Copy link
Collaborator

@clint156 clint156 commented Nov 9, 2023

Description

Please provide a summary of the pull request and the issue it resolves. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Resolves #(add issue number here and remove parentheses)

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@clint156 clint156 linked an issue Nov 9, 2023 that may be closed by this pull request
@clint156 clint156 merged commit 5dbbfb2 into develop Nov 9, 2023
2 checks passed
@clint156 clint156 deleted the 33-bug-coordinates-for-some-buildings-are-rounding branch November 9, 2023 15:15
clint156 added a commit that referenced this pull request Nov 9, 2023
* Release v2.0.6

* [#26] Fix permissions (#27)

* Fix permissions, fix issue templates, fix docs, upgrade dependencies

* update changelog

* update gitignore

* Release v2.0.7

* 28 prepare for deployment in openshift (#29)

* Add environments vars to app-env.json

* Upgrade dependencies

* fix changelog

---------

Co-authored-by: Stephen Hurwit <[email protected]>

* Release v2.0.8

* Release v2.0.9

* Release v2.0.10

* 33 bug coordinates for some buildings are rounding (#34)

* change building coords to float64 from float32

* changed auth token requirement on wayfinding end points to client.Standard

* Release v2.0.12

---------

Co-authored-by: Stephen Hurwit <[email protected]>
Co-authored-by: Stephen Hurwit <[email protected]>
Co-authored-by: akshadpai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Coordinates for some buildings are rounding
1 participant