Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ID-52]Delete tps events API #53

Merged
merged 19 commits into from
Mar 18, 2024
Merged

[ID-52]Delete tps events API #53

merged 19 commits into from
Mar 18, 2024

Conversation

stefanvit
Copy link
Collaborator

Description

Delete tps events API by []ids

**Resolves #52

Review Time Estimate

  • Immediately
  • Within a week
  • When possible

Type of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@stefanvit stefanvit requested a review from petyos March 8, 2024 14:13
@stefanvit stefanvit requested a review from clint156 as a code owner March 8, 2024 14:13
@stefanvit stefanvit linked an issue Mar 8, 2024 that may be closed by this pull request
Delete tps events API #52
Closed
petyos
petyos requested changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@petyos petyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call me to discuss this PR.

@stefanvit stefanvit requested a review from petyos March 12, 2024 18:23
Stefan Vitanov and others added 11 commits March 15, 2024 13:09
Merge branch 'develop' into 52-delete-tps-events-api
1aef95f 
* develop:
  [ID-47]Create tps events API  (#48)

# Conflicts:
#	.secrets.baseline
#	CHANGELOG.md
#	core/apis_tps.go
#	core/interfaces.go
#	core/model/legacyEvents.go
#	driver/web/adapter.go
#	driver/web/apis_tps.go
#	driver/web/docs/gen/def.yaml
#	driver/web/docs/index.yaml
#	driver/web/tps_permission_policy.csv
fix permission_policy
1611ea1
fix the API also small fixes for create Event API
7903b96
@petyos
It is location but not locations
0731aa1
@petyos
Do not put create info where it is not needed.
7e068b1
@petyos
Use the same approach when naming functions
d615264
@petyos
Document the delete API
355ffeb
@petyos
It is tps token but not admin token
020c007
@petyos
Do not use shared
77a25a7
@petyos
Use list but not map
fa61b28
fix
0155042
@stefanvit stefanvit merged commit b6a4958 into develop Mar 18, 2024
2 checks passed
@stefanvit stefanvit deleted the 52-delete-tps-events-api branch March 18, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clint156 clint156 Awaiting requested review from clint156 clint156 is a code owner

@petyos petyos Awaiting requested review from petyos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete tps events API
2 participants
@stefanvit @petyos